fix: remove duplicate hero search box causing homepage confusion - #49
Merged
Conversation
AJ relayed user feedback: "唔知打邊個框去搜" (don't know which box to search in). Root cause: the hero section stacked TWO nearly-identical input+button rows right on top of each other -- .search-bar (#heroTicker, "輸入股票代號 AAPL" -> ai-analysis.html) directly above .ask-ai-bar (#heroAskAi, "直接問AI" -> chat.html), both the same visual shape. Fix: remove the .ask-ai-bar block from the hero across index.html + all 18 language copies (same duplicated-per-locale structure as the rest of this site). The free-text "ask AI anything" capability isn't lost -- the "免費體驗" demo section further down the page (#demoTicker) already handles both bare tickers AND free-text questions via the existing XFLSmartRouter (js/smart-router.js), so this removes the confusing duplicate rather than removing functionality. Scoped to just the HTML block (verified via automated div-tag-balance check across all 19 files before/after) -- goAskAi()/heroAskAi CSS classes are left in place as inert dead code rather than touched, to keep this diff minimal and low-risk on a live marketing page. Unrelated pre-existing test failure noted, not caused by this change: tests/step_defs/test_i18n_coverage.py flags 'profile_save_btn' missing in 43 languages in services/i18n.py (untouched by this commit).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AJ relayed user feedback: "唔知打邊個框去搜" (don't know which box to search in). Root cause: the hero section stacked TWO nearly-identical input+button rows right on top of each other -- .search-bar (#heroTicker, "輸入股票代號 AAPL" -> ai-analysis.html) directly above .ask-ai-bar (#heroAskAi, "直接問AI" -> chat.html), both the same visual shape.
Fix: remove the .ask-ai-bar block from the hero across index.html + all 18 language copies (same duplicated-per-locale structure as the rest of this site). The free-text "ask AI anything" capability isn't lost -- the "免費體驗" demo section further down the page (#demoTicker) already handles both bare tickers AND free-text questions via the existing XFLSmartRouter (js/smart-router.js), so this removes the confusing duplicate rather than removing functionality.
Scoped to just the HTML block (verified via automated div-tag-balance check across all 19 files before/after) -- goAskAi()/heroAskAi CSS classes are left in place as inert dead code rather than touched, to keep this diff minimal and low-risk on a live marketing page.
Unrelated pre-existing test failure noted, not caused by this change: tests/step_defs/test_i18n_coverage.py flags 'profile_save_btn' missing in 43 languages in services/i18n.py (untouched by this commit).