fix: add missing profile_save_btn i18n key to 43 languages - #50
Merged
Conversation
tests/step_defs/test_i18n_coverage.py flagged a pre-existing gap:
'profile_save_btn' ("Save name / icon" -- the profile settings save
button) only existed in en/zh-HK/zh-TW/zh-CN, missing from the other
43 supported languages. Not caused by any recent change -- found while
verifying an unrelated homepage fix.
Added a translated value to each of the 43 language blocks in
services/i18n.py, inserted right after topbar_account/before
share_btn_label (matching the existing zh-HK/zh-TW/zh-CN placement) via
a scripted insertion keyed off each block's own header, so every
language got the key exactly once and no other translations were
touched.
Verified: py_compile clean, i18n_coverage BDD test now passes (was
failing before this commit), backend boots with 66 routes, test_level1
still 4 passed/1 skipped.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/step_defs/test_i18n_coverage.py flagged a pre-existing gap: 'profile_save_btn' ("Save name / icon" -- the profile settings save button) only existed in en/zh-HK/zh-TW/zh-CN, missing from the other 43 supported languages. Not caused by any recent change -- found while verifying an unrelated homepage fix.
Added a translated value to each of the 43 language blocks in services/i18n.py, inserted right after topbar_account/before share_btn_label (matching the existing zh-HK/zh-TW/zh-CN placement) via a scripted insertion keyed off each block's own header, so every language got the key exactly once and no other translations were touched.
Verified: py_compile clean, i18n_coverage BDD test now passes (was failing before this commit), backend boots with 66 routes, test_level1 still 4 passed/1 skipped.