Open
Conversation
spaghetti-squash
requested changes
Nov 22, 2023
Contributor
spaghetti-squash
left a comment
spaghetti-squash
left a comment
There was a problem hiding this comment.
A few quibbles, but mostly I'm not sure if this is actually better than just using our existing code for freekills like Free For All; feels like we should kinda just do that. Which I do assume for most players would get bofa stuff; I believe the wanderer type there is "freefight" but I'm not 100% sure offhand.
If you do do that, be sure to pass the spec from the freekill into the wanderer function
Comment on lines
+185
to
+189
| import { | ||
| canAdventureOrUnlock, | ||
| canWander, | ||
| unlock, | ||
| } from "garbo-lib/dist/wanderer/lib"; |
Contributor
There was a problem hiding this comment.
This isn't how we should accomplish this; we should either use a new wanderer type or an existing wanderer type, or export those functions from garbo-lib through ./wanderer
Co-authored-by: neil <78829653+horrible-little-slime@users.noreply.github.com>
Co-authored-by: neil <78829653+horrible-little-slime@users.noreply.github.com>
Co-authored-by: neil <78829653+horrible-little-slime@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.