Fix references to wrong match group in zk-id-regexp#66
Open
boyechko wants to merge 4 commits intolocalauthor:mainfrom
Open
Fix references to wrong match group in zk-id-regexp#66boyechko wants to merge 4 commits intolocalauthor:mainfrom
boyechko wants to merge 4 commits intolocalauthor:mainfrom
Conversation
`zk-id-regexp` does not specify that the regexp should be wrapped in `\\(...\\)`, but some code that matches against the regexp refers to match-string 1 while other instances (e.g. `zk--id-at-point`) do not. Since `zk-link-regexp` and `zk-file-name-regexp` add their own explicitly-numbered capture groups, it's best to consistently refer to the entire match when matching against `zk-id-regexp`.
Removing `\\(...\\)` is not strictly needed, but since both `zk-link-regexp` and `zk-file-name-regexp` add capture groups themselves, it results in a cleaner regexp.
boyechko
added a commit
to boyechko/octavo
that referenced
this pull request
Aug 20, 2023
boyechko
added a commit
to boyechko/octavo
that referenced
this pull request
Sep 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this accidentally when testing some different values for
zk-id-regexp, which made zk-index completely inoperable, since button actions were not finding the note ID.The docstring does not specify that the regexp should be wrapped in
\\(...\\), but some code that matches against the regexp refers to match-string 1 while other instances (e.g.zk--id-at-point) reference the entire match (i.e. match-string 0). Sincezk-link-regexpandzk-file-name-regexpadd their own explicitly-numbered capture groups, it's best to consistently refer to the entire match when matching againstzk-id-regexp.NB: This pull request would need to be applied before pull request #68, but otherwise there shouldn't be any conflicts.