Fix OpenCV 5 compatibility in camera calibration reprojection error calculation#306
Open
tanmoykalita808 wants to merge 2 commits into
Open
Conversation
Author
|
Hi, just checking in to see if there's anything I can help with regarding this PR. I'm happy to make any changes or run additional tests if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a fix for one of the OpenCV 5 compatibility issues discussed in #302.
Problem
While testing with:
tests/test_cameraconfig.py::test_camera_calibfailed during the reprojection error calculation insidecalibrate_camera().The point arrays returned by
cv2.projectPoints()and the detected chessboard corner points had different array layouts, causingcv2.norm()to fail with an input type mismatch.Solution
Normalize both point arrays to shape
(N, 2)before computing the reprojection error.The same change is applied in both reprojection error calculation paths.
Validation
cv2.projectPoints()using a minimal example.tests/test_cameraconfig.py::test_camera_calibpasses after the change.Thanks for the guidance on targeting the
302-opencv-5branch. I'm happy to make any additional changes if needed to maintain backward compatibility.