fix(text-morph): reset dimensions on zero-size early return in transitionContainerSize#44
Open
loicnico96 wants to merge 1 commit intolochie:mainfrom
Open
Conversation
…tionContainerSize When text is cleared and a new character is typed before the fade animation completes, element.offsetWidth returns 0 (the CSS target), triggering the early-return guard. Previously this left inline width/height pinned at 0px permanently. Now we reset to 'auto' before returning so the container reverts to natural content sizing. Fixes lochie#43
|
@loicnico96 is attempting to deploy a commit to the Lochie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunate timing may cause
transitionContainerSizeto be called with 0 oldWidth/oldHeight while0pxwidth/height css are being applied - hitting the early-return guard and permanently leaving the css at0px(as that does not get reset anywhere else). This PR resets to 'auto' before returning so the container reverts to natural content sizing.Fixes #43