fix: add type-safe preset names to HapticInput#37
Open
abed-daloopa wants to merge 3 commits intolochie:mainfrom
Open
fix: add type-safe preset names to HapticInput#37abed-daloopa wants to merge 3 commits intolochie:mainfrom
abed-daloopa wants to merge 3 commits intolochie:mainfrom
Conversation
HapticInput now includes DefaultPatternName (a union of preset keys like
"success", "error", "warning", etc.) so IDEs provide autocomplete while
still accepting arbitrary strings via (string & {}).
HapticInput now uses DefaultPatternName (a union of preset keys like "success", "error", "warning", etc.) instead of bare string, giving IDE autocomplete and compile-time safety. Arbitrary strings are no longer accepted since there is no custom pattern registration API.
|
@abed-daloopa is attempting to deploy a commit to the Lochie Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HapticInputnow usesDefaultPatternName(union of preset keys like"success","error","warning", etc.) instead of barestring, giving IDE autocomplete and compile-time safetyDefaultPatternNametype from the public APITest plan
trigger("success")autocompletes in IDEtrigger("invalid")shows a type errorpnpm buildpasses