Skip to content

fix: fix svelte export #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tijnjh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: fix svelte export #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/web-haptics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"access": "public"
},
"scripts": {
"build": "tsup",
"build": "rm -rf dist && tsup",
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build script now uses rm -rf, which is not portable (breaks on Windows shells) and introduces a new environment assumption compared to the rest of the repo. Prefer a cross-platform clean step (e.g., node -e using fs.rmSync(..., { recursive: true, force: true }), or add/use a rimraf-style tool) so pnpm build works consistently across OSes.

Suggested change
"build": "rm -rf dist && tsup",
"build": "node -e \"require('fs').rmSync('dist', { recursive: true, force: true });\" && tsup",

Copilot uses AI. Check for mistakes.
"dev": "tsup --watch",
"lint": "eslint -c .eslintrc.cjs ./src/**/*.{ts,tsx}",
"lint:fix": "eslint --fix -c .eslintrc.cjs ./src/**/*.{ts,tsx}",
Expand Down
1 change: 0 additions & 1 deletion packages/web-haptics/tsup.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export default defineConfig((options) => [
},
format: ["cjs", "esm"],
dts: true,
clean: true,
sourcemap: false,
target: "es2022",
external: ["react"],
Expand Down
Loading