[BUG] sourceopt.formatHtml options not working

[NitinParri]

With the latest main branche the setting sourceopt.formatHtml value 1 to 5 all have the same format.
They all use Dindent and there are no format options available.

There should be at least 3 options:

1. Off
2. No line break at all, code in one line (former sourceopt.formatHtml = 1)
3. With Dindent (former sourceopt.formatHtml = 4)

[chrissonntag]

Confirmed — this broke in #161 when the old formatHtml() was replaced by Dindent: CleanHtmlService::clean() now just does if ($this->formatType), so 1–5 all take the same branch.

Worth noting it can't really be fixed inside sourceopt, because Dindent has no concept of line-break levels at all. So realistically two ways out: either revert #161 and bring the old formatter back, or add the levels upstream in schleuse/dindent and drive them from here. The latter pairs with #172, which needs a patch over there anyway.

So I leave it up to @xerc to decide whether or not to patch or revert.

[NitinParri]

With #172 in mind I would say revert and bring the old formatter back.

[xerc]

it was intentional ; you may post-process -OR- duplicate Dindent including xerc/dindent@e024e4b + Schleuse/dindent@74fbd94

[chrissonntag]

What was even the purpose of switching to Dindent, especially regarding it's a rather unmaintained project? Without any specific reason, I'd lean towards reverting the switch as well.

[xerc]

HTML does not change a lot :) the re-formater was not optimized and i only used formatHtml #4 & sometimes #1 (which should be very easy to include)

[chrissonntag]

IMHO we should really switch back. Having a dependency on a project that is not sophisticated enough to cover the needs of sourceopt, seems rather non-sensical. Considering the code that has been exchanged for it, was not that much and can easily be maintained by us, the most logical thing to me is to get back to "good old days" 😆 How about @lochmueller pins it down 😉

[lochmueller]

I would prefer the split packages (one for the HTML format integration in PHP like dendent and one for the TYPO3 integration EXT:sourceopt). I would suggest adding a option to get a null value to indentation_character (in this case: documentation says... null removes all line-breaks) to get the "formatHtml = 1" option back. The options 2-3 are not needed I think. Regards, Tim

[chrissonntag]

Ok, done. The dependency will be kept for now for I was not able to find any other project fitting the needs. So we stick with schleuse/dindent for now and see what the future brings for us.