feat: add Gloas payload status to node notifier

packages/beacon-node/src/node/notifier.ts

@@ -1,6 +1,6 @@
 import {BeaconConfig} from "@lodestar/config";
-import {ExecutionStatus, ProtoBlock} from "@lodestar/fork-choice";
-import {EPOCHS_PER_SYNC_COMMITTEE_PERIOD, SLOTS_PER_EPOCH} from "@lodestar/params";
+import {ExecutionStatus, PayloadStatus, ProtoBlock} from "@lodestar/fork-choice";
+import {EPOCHS_PER_SYNC_COMMITTEE_PERIOD, SLOTS_PER_EPOCH, isForkPostGloas} from "@lodestar/params";
 import {
   IBeaconStateView,
   computeEpochAtSlot,
@@ -19,6 +19,11 @@ import {TimeSeries} from "../util/timeSeries.js";
 /** Create a warning log whenever the peer count is at or below this value */
 const WARN_PEER_COUNT = 1;
 
+/** Notifier log point as basis points of the slot: 5000 BPS = half-slot (pre-Gloas). */
+const NOTIFIER_LOG_DUE_BPS = 5000;
+/** Notifier log point for Gloas: 8333 BPS ≈ 5/6 of slot — past PTC deadline so the head has transitioned from PENDING to FULL/EMPTY. */
+const NOTIFIER_LOG_DUE_BPS_GLOAS = 8333;
+
 type NodeNotifierModules = {
   network: INetwork;
   chain: IBeaconChain;
@@ -127,8 +132,9 @@ export async function runNodeNotifier(modules: NodeNotifierModules): Promise<voi
         logger.info(`New sync committee period ${period}`);
       }
 
-      // Log halfway through each slot
-      await sleep(timeToNextHalfSlot(config, chain, isFirstTime), signal);
+      // Log once per slot, after the slot's main events have settled
+      // (halfway for pre-Gloas, 5/6 for Gloas to let PTC votes land — spec PR #4884)
+      await sleep(timeToNextLogPoint(config, chain, isFirstTime), signal);
       isFirstTime = false;
     }
   } catch (e) {
@@ -139,22 +145,33 @@ export async function runNodeNotifier(modules: NodeNotifierModules): Promise<voi
   }
 }
 
-function timeToNextHalfSlot(config: BeaconConfig, chain: IBeaconChain, isFirstTime: boolean): number {
+function timeToNextLogPoint(config: BeaconConfig, chain: IBeaconChain, isFirstTime: boolean): number {
   const msPerSlot = config.SLOT_DURATION_MS;
-  const msPerHalfSlot = msPerSlot / 2;
   const msFromGenesis = Date.now() - chain.genesisTime * 1000;
   const msToNextSlot =
     msFromGenesis < 0
       ? // For future genesis time, calculate time left in the slot
         -msFromGenesis % msPerSlot
       : // For past genesis time, calculate time until the next slot
         msPerSlot - (msFromGenesis % msPerSlot);
+
+  // In Gloas, PTC votes decide payload timeliness around 2/3 of the slot; log at 5/6 so the
+  // head has transitioned from PENDING to FULL/EMPTY. Pre-Gloas keeps the half-slot cadence.
+  const currentSlot = chain.clock.currentSlot;
+  const logDueBps = isForkPostGloas(config.getForkName(currentSlot))
+    ? NOTIFIER_LOG_DUE_BPS_GLOAS
+    : NOTIFIER_LOG_DUE_BPS;
+  const msSlotOffset = config.getSlotComponentDurationMs(logDueBps);
+
   if (isFirstTime) {
-    // at the 1st time we may miss middle of the current clock slot
-    return msToNextSlot > msPerHalfSlot ? msToNextSlot - msPerHalfSlot : msToNextSlot + msPerHalfSlot;
+    // at the 1st time we may miss the log point of the current clock slot
+    const msToSlotEndFromLogPoint = msPerSlot - msSlotOffset;
+    return msToNextSlot > msToSlotEndFromLogPoint
+      ? msToNextSlot - msToSlotEndFromLogPoint
+      : msToNextSlot + msSlotOffset;
   }
-  // after the 1st time always wait until middle of next clock slot
-  return msToNextSlot + msPerHalfSlot;
+  // after the 1st time always wait until the log point of the next clock slot
+  return msToNextSlot + msSlotOffset;
 }
 
 function getHeadExecutionInfo(
@@ -167,6 +184,13 @@ function getHeadExecutionInfo(
     return [];
   }
 
+  const fork = config.getForkName(headInfo.slot);
+
+  // Gloas: show payload status (PENDING/EMPTY/FULL) instead of EL execution status
+  if (isForkPostGloas(fork)) {
+    return getGloasExecutionInfo(headInfo);
+  }
+
   const executionStatusStr = headInfo.executionStatus.toLowerCase();
 
   // Add execution status to notifier only if head is on/post bellatrix
@@ -187,3 +211,21 @@ function getHeadExecutionInfo(
 
   return [];
 }
+
+/** Gloas-specific execution info showing payload status and block details */
+function getGloasExecutionInfo(headInfo: ProtoBlock): string[] {
+  const payloadStatusStr =
+    headInfo.payloadStatus === PayloadStatus.FULL
+      ? "full"
+      : headInfo.payloadStatus === PayloadStatus.EMPTY
+        ? "empty"
+        : "pending";
+
+  if (headInfo.payloadStatus === PayloadStatus.FULL && headInfo.executionPayloadBlockHash !== null) {
+    const hashInfo = prettyBytesShort(headInfo.executionPayloadBlockHash);
+    const numberInfo = headInfo.executionPayloadNumber;
+    return [`payload: ${payloadStatusStr}(${numberInfo} ${hashInfo})`];
+  }
+
+  return [`payload: ${payloadStatusStr}`];
+}