TID #011 Common Libs: Create a common library for both app and machine#4
Open
loerac wants to merge 7 commits into
Open
TID #011 Common Libs: Create a common library for both app and machine#4loerac wants to merge 7 commits into
loerac wants to merge 7 commits into
Conversation
Create a directory to store common libraries under the /usr/local/shared
embunny96
approved these changes
Sep 3, 2020
Collaborator
embunny96
left a comment
embunny96
left a comment
There was a problem hiding this comment.
Looks pretty good, whenever I have a logger at work we include a current timestamp because it helps a lot in any case of troubleshooting. Just a thought.
Owner
Author
What do you mean by that @embunny96 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synopsis:
Having the same file path in both app and machine seems messy, better to have common library to store shared resources
Description:
The log file was hard coded into both the app and machine. If for some reason, this would be updated in the future, we would have to update it on both sides
Test:
Both app and machine are still logging to the same file location.
