Update to new avr/pgmspace Syntax#4
Open
malexmave wants to merge 10 commits intologicalzero:masterfrom
Open
Conversation
added 10 commits
December 30, 2012 12:58
…ables. Old Syntax was PROGMEM prog_uchar..., new Syntax is PROGMEM const unsigned char... Same goes for prog_uint16 (const uint16) and friends. The example files have NOT been updated yet, and the changes have not been tested properly.
FirstTest now uses the new Syntax and should work properly.
Updated the Template to use the new Syntax, plus fixed a bug (setup() loaded gamby.palette = blocks;, but blocks did not exist. Made it load the corrent thing (palette, the PROGMEM constant) instead).
Updated TextModeTemplate to the new Syntax.
AnimatedSprites updated to the new Syntax.
Updated to the new Syntax.
This file did not need any updates to the new Syntax, but I used this chance to remove two spare newlines from the end of the file ;-)
Updated SimianSays to the new Syntax.
Owner
|
Did you upgrade the AVR toolchain manually? The version bundled with the current Mac and Windows Arduino IDE is the earlier one with the specialized PROGMEM types. The current Arduino documentation still advises against using normal data types with PROGMEM. |
Author
|
I just Edit: If there are version differences between Mac OS / Windows / other Linux and Mint 14, you can probably just merge this into a branch and add a notice about "If it doesn't work with the first version, try this branch" or something similar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in Issue #3, the syntax for PROGMEM has changed from
PROGMEM prog_*toPROGMEM const *, with * being the variable types. Additionally,prog_ucharhas been changed toconst unsigned char.I have implemented those changes in the libraries and updated all the examples to use the changed stuff. As far as I know, everything compiles and works flawlessly.
Sincerely,
malexmave