feat: http server based key package registry#124
Open
kaichaosun wants to merge 12 commits into
Open
Conversation
kaichaosun
force-pushed
the
http-key-registry
branch
4 times, most recently
from
3705d27 to
3683ba5
Compare
jazzz
reviewed
Jun 2, 2026
jazzz
approved these changes
Jun 2, 2026
Collaborator
jazzz
left a comment
jazzz
left a comment
There was a problem hiding this comment.
I think these are good changes.
- Great use of the extensions to store configurable service implementations.
High Level, for future PRs we'd like to see:
- Chat-cli become leaner and simpler.
- Developer Choice + Sensible defaults: Its good to give developers options to configure, but we should also have a default code path, that is simple and straight forward to use.
Once AccountId has been decoupled from DeviceIdentity, I'd be happy to merge.
kaichaosun
force-pushed
the
http-key-registry
branch
from
3683ba5 to
ff0e001
Compare
kaichaosun
force-pushed
the
http-key-registry
branch
from
32c2463 to
ebe0ebf
Compare
kaichaosun
force-pushed
the
http-key-registry
branch
from
ebe0ebf to
3f02564
Compare
kaichaosun
force-pushed
the
http-key-registry
branch
from
f4c74e3 to
83244d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
--registry-urlflag on chat-cli. Without the flag, behavior is unchanged.Fix #110.