Update chronicles#33
Conversation
markspanbroek
commented
Sep 24, 2025
- allow for newer version of chronicles
- add nimble lock
7e90852 to
8ab79db
Compare
emizzle
left a comment
There was a problem hiding this comment.
Thanks for the PR Mark! Just curious why you decided not to use a version range? Not blocking, so will approve now 👍
| # Dependencies | ||
| requires "nim >= 1.6.14" | ||
| requires "chronicles >= 0.10.3 & < 0.11.0" | ||
| requires "chronicles >= 0.10.3" |
There was a problem hiding this comment.
Out of curiosity, why did you decide to not use a version range?
There was a problem hiding this comment.
Apologies for the late reply. I have been working with a large number of nimble dependencies lately, and I ran into quite a few bugs in the nimble algorithm. Both the nimble version that comes with nim 2.2.4 and the latest nimble version didn't handle version ranges very well in some cases. I gave up on the upper bounds, and rely on nimble lock files to not have breakage whenever a dependency updates in an incompatible manner.
|
@markspanbroek I can't merge due to the unsigned commits. Would you be able to re-commit using a signature? If not, no worries, I can cherry-pick from your branch, but I don't want to take credit for your work. |
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
658a53c to
92f3616
Compare
I updated the branch with signed commits. Thanks for being considerate about taking credit, but I don't think that you need to worry. If I remember correctly then cherry-picking or rebasing will still keep my name as author of the commit. Your name would then appear as the committer. |
|
Thanks mark 🙏 |