Skip to content

Update chronicles#33

Merged
emizzle merged 4 commits into
logos-storage:masterfrom
durability-labs:update-chronicles
Oct 28, 2025
Merged

Update chronicles#33
emizzle merged 4 commits into
logos-storage:masterfrom
durability-labs:update-chronicles

Conversation

@markspanbroek
Copy link
Copy Markdown
Contributor

  • allow for newer version of chronicles
  • add nimble lock

Copy link
Copy Markdown
Collaborator

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Mark! Just curious why you decided not to use a version range? Not blocking, so will approve now 👍

Comment thread serde.nimble
# Dependencies
requires "nim >= 1.6.14"
requires "chronicles >= 0.10.3 & < 0.11.0"
requires "chronicles >= 0.10.3"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did you decide to not use a version range?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply. I have been working with a large number of nimble dependencies lately, and I ran into quite a few bugs in the nimble algorithm. Both the nimble version that comes with nim 2.2.4 and the latest nimble version didn't handle version ranges very well in some cases. I gave up on the upper bounds, and rely on nimble lock files to not have breakage whenever a dependency updates in an incompatible manner.

@emizzle
Copy link
Copy Markdown
Collaborator

emizzle commented Oct 27, 2025

@markspanbroek I can't merge due to the unsigned commits. Would you be able to re-commit using a signature? If not, no worries, I can cherry-pick from your branch, but I don't want to take credit for your work.

Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
Signed-off-by: Mark Spanbroek <mark@spanbroek.net>
@markspanbroek
Copy link
Copy Markdown
Contributor Author

@markspanbroek I can't merge due to the unsigned commits. Would you be able to re-commit using a signature? If not, no worries, I can cherry-pick from your branch, but I don't want to take credit for your work.

I updated the branch with signed commits. Thanks for being considerate about taking credit, but I don't think that you need to worry. If I remember correctly then cherry-picking or rebasing will still keep my name as author of the commit. Your name would then appear as the committer.

@emizzle
Copy link
Copy Markdown
Collaborator

emizzle commented Oct 28, 2025

Thanks mark 🙏

@emizzle emizzle merged commit 60fcbda into logos-storage:master Oct 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants