Upgrade elasticsearch ruby client and remove 7.x related logics#213
Upgrade elasticsearch ruby client and remove 7.x related logics#213mashhurs wants to merge 7 commits into
elasticsearch ruby client and remove 7.x related logics#213Conversation
alexcams
left a comment
There was a problem hiding this comment.
Just a minor suggestion and a question about test coverage.
…as it was before depending on the client type. Remove dead spec logics never get executed.
73c75de to
6dfb9a5
Compare
elasticsearch ruby client and remove 7.x stack related logicselasticsearch ruby client and remove 7.x client patch logics
elasticsearch ruby client and remove 7.x client patch logicselasticsearch ruby client and remove 7.x ES client patch logics
elasticsearch ruby client and remove 7.x ES client patch logicselasticsearch ruby client and remove 7.x related logics
|
/pr_prepare release: minor
|
|
Hey @mashhurs! You'd need to remove the existing changelog entry for the automation to work correctly. The workflow detects if there have been changes in the changelog but not in version file when the PR is open and adds a comment: Since this PR was open before main branch had the workflow added, that preventing message hasn't been posted. |
Ah, thank you for letting know, didn't notice. I have just removed it. |
|
CI failures are due to the I will hold off merging till the point we will have a clear direction either sanitize duplicate headers or fix in the upstream. |
TODO: add changelog
elasticsearchclient, remove 7.x patch logics #212