Skip to content

Upgrade elasticsearch ruby client and remove 7.x related logics#213

Open
mashhurs wants to merge 7 commits into
logstash-plugins:mainfrom
mashhurs:upgrade-es-client-and-remove-7.x-logics
Open

Upgrade elasticsearch ruby client and remove 7.x related logics#213
mashhurs wants to merge 7 commits into
logstash-plugins:mainfrom
mashhurs:upgrade-es-client-and-remove-7.x-logics

Conversation

@mashhurs
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs commented Apr 27, 2026

@mashhurs mashhurs self-assigned this Apr 27, 2026
Comment thread spec/filters/elasticsearch_dsl_spec.rb
Copy link
Copy Markdown
Contributor

@alexcams alexcams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion and a question about test coverage.

Comment thread lib/logstash/filters/elasticsearch/client.rb Outdated
Comment thread spec/filters/elasticsearch_dsl_spec.rb
mashhurs added 3 commits May 4, 2026 12:09
…as it was before depending on the client type. Remove dead spec logics never get executed.
@mashhurs mashhurs force-pushed the upgrade-es-client-and-remove-7.x-logics branch from 73c75de to 6dfb9a5 Compare May 4, 2026 20:41
Copy link
Copy Markdown
Contributor

@alexcams alexcams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! when CI is green. Maybe someone else has something to say.

@mashhurs mashhurs requested a review from yaauie May 4, 2026 21:55
@mashhurs mashhurs changed the title Upgrade elasticsearch ruby client and remove 7.x stack related logics Upgrade elasticsearch ruby client and remove 7.x client patch logics May 4, 2026
@mashhurs mashhurs changed the title Upgrade elasticsearch ruby client and remove 7.x client patch logics Upgrade elasticsearch ruby client and remove 7.x ES client patch logics May 4, 2026
@mashhurs mashhurs changed the title Upgrade elasticsearch ruby client and remove 7.x ES client patch logics Upgrade elasticsearch ruby client and remove 7.x related logics May 12, 2026
@mashhurs
Copy link
Copy Markdown
Contributor Author

/pr_prepare release: minor

  • Drop a support for Logstash 7.x by requiring elasticsearch gem >= 8. Logstash 8+ continues to work as before.

@mashhurs mashhurs requested a review from kaisecheng May 19, 2026 22:28
@alexcams
Copy link
Copy Markdown
Contributor

Hey @mashhurs!

You'd need to remove the existing changelog entry for the automation to work correctly.

The workflow detects if there have been changes in the changelog but not in version file when the PR is open and adds a comment:
This PR updates the changelog but does not update the plugin version. Please check if the current plugin version is already published on [RubyGems](https://rubygems.org/). If it is, a version bump is needed.

Since this PR was open before main branch had the workflow added, that preventing message hasn't been posted.

@mashhurs
Copy link
Copy Markdown
Contributor Author

Hey @mashhurs!

You'd need to remove the existing changelog entry for the automation to work correctly.

The workflow detects if there have been changes in the changelog but not in version file when the PR is open and adds a comment: This PR updates the changelog but does not update the plugin version. Please check if the current plugin version is already published on [RubyGems](https://rubygems.org/). If it is, a version bump is needed.

Since this PR was open before main branch had the workflow added, that preventing message hasn't been posted.

Ah, thank you for letting know, didn't notice. I have just removed it.

@mashhurs mashhurs mentioned this pull request May 21, 2026
@mashhurs
Copy link
Copy Markdown
Contributor Author

CI failures are due to the elasticsearch-ruby client v9.4.1 version which is setting duplicate headers (Content-Type and content-type), details are here -
elastic/elasticsearch-ruby@ff9ec8f#r186029959

I will hold off merging till the point we will have a clear direction either sanitize duplicate headers or fix in the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade elasticsearch client, remove 7.x patch logics

2 participants