Allow upgrading elasticsearch ruby client and remove its 7.x patch logics.#252
Allow upgrading elasticsearch ruby client and remove its 7.x patch logics.#252mashhurs wants to merge 6 commits into
Conversation
…on Update workflow trigger
Changelog and Version ManagementNo changelog or version changes detected. You can either update them manually or use a comment command to update them automatically on merge:
Omit the entry line to use the PR title. If multiple commands are posted, the last one wins. |
|
/pr_prepare release: minor
|
There was a problem hiding this comment.
Thanks for the cleanup! One concern on the version bump. I believe it should be at least a 'minor' because upgrading gem version is not a bug fix and this change will block 7.17 user to install. I tested in 7.17.25 and confirmed that user can still install es-input 5.2.2.
I'd suggest minor/ major with a note in the changelog
- Drop support for Logstash 7.x by requiring `elasticsearch` gem >= 8.
Logstash 8+ continues to work as before.
Yep, just updated the changelog/version-bump request. As we discussed in the weekly, I will add release note when this change will be embedded in LS core and I have opened an issue if there anything more we need follow up - #254 |
This PR drops a support for Logstash 7.x although plugin still can be installed.