Skip to content

Allow upgrading elasticsearch ruby client and remove its 7.x patch logics.#252

Open
mashhurs wants to merge 6 commits into
logstash-plugins:mainfrom
mashhurs:upgrade-es-client-and-remove-7.x-logics
Open

Allow upgrading elasticsearch ruby client and remove its 7.x patch logics.#252
mashhurs wants to merge 6 commits into
logstash-plugins:mainfrom
mashhurs:upgrade-es-client-and-remove-7.x-logics

Conversation

@mashhurs
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs commented May 5, 2026

This PR drops a support for Logstash 7.x although plugin still can be installed.

  • removes elasticsearch 7.x specific patch logics
  • allow upgrading elasticsearch ruby client up to 9.x versions

@mashhurs mashhurs marked this pull request as draft May 5, 2026 18:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Changelog and Version Management

No changelog or version changes detected. You can either update them manually or use a comment command to update them automatically on merge:

/pr_prepare release:<patch|minor|major> — bump version + update changelog
/pr_prepare changelog:add — changelog entry only (no version bump)

/pr_prepare release:patch
- Add the changelog entry here
  - (Additional details can be provided in multiple lines, respecting markdown formatting)

Omit the entry line to use the PR title. If multiple commands are posted, the last one wins.

@mashhurs mashhurs marked this pull request as ready for review May 12, 2026 22:46
@mashhurs
Copy link
Copy Markdown
Contributor Author

mashhurs commented May 12, 2026

/pr_prepare release: minor

  • Drop a support for Logstash 7.x by requiring elasticsearch gem >= 8. Logstash 8+ continues to work as before.

@mashhurs mashhurs requested a review from kaisecheng May 12, 2026 22:52
Copy link
Copy Markdown
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! One concern on the version bump. I believe it should be at least a 'minor' because upgrading gem version is not a bug fix and this change will block 7.17 user to install. I tested in 7.17.25 and confirmed that user can still install es-input 5.2.2.

I'd suggest minor/ major with a note in the changelog

  - Drop support for Logstash 7.x by requiring `elasticsearch` gem >= 8.
    Logstash 8+ continues to work as before.

@mashhurs
Copy link
Copy Markdown
Contributor Author

Thanks for the cleanup! One concern on the version bump. I believe it should be at least a 'minor' because upgrading gem version is not a bug fix and this change will block 7.17 user to install. I tested in 7.17.25 and confirmed that user can still install es-input 5.2.2.

I'd suggest minor/ major with a note in the changelog

  - Drop support for Logstash 7.x by requiring `elasticsearch` gem >= 8.
    Logstash 8+ continues to work as before.

Yep, just updated the changelog/version-bump request. As we discussed in the weekly, I will add release note when this change will be embedded in LS core and I have opened an issue if there anything more we need follow up - #254

@mashhurs mashhurs requested a review from kaisecheng May 19, 2026 19:36
Copy link
Copy Markdown
Contributor

@kaisecheng kaisecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants