Skip to content

log on exception, and continue event processing#51

Open
Cactusbone wants to merge 4 commits into
logstash-plugins:mainfrom
F4-Group:log_on_exception
Open

log on exception, and continue event processing#51
Cactusbone wants to merge 4 commits into
logstash-plugins:mainfrom
F4-Group:log_on_exception

Conversation

@Cactusbone
Copy link
Copy Markdown

log on exception, and continue event processing.

This should allow for easier debugging ( crash won't be lost in thousands of SocketError: bind: name or service not known logs)

and also won't stop logs processing...

@jlecour
Copy link
Copy Markdown

jlecour commented Oct 22, 2016

Thank you for this patch.

To make the whole problem disappear, those lines must also be in a begin/rescue block : https://github.com/F4-Group/logstash-input-gelf/blob/d525918876ccc86cb904be504eb71783336a7854/lib/logstash/inputs/gelf.rb#L110-L114

@Cactusbone
Copy link
Copy Markdown
Author

Cactusbone commented Oct 24, 2016

Indeed, you're right !

I'll try adding some useful info after a few tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants