Skip to content

Update documentation: packet-wise flag is called cap not add-cap - #3018

Merged
lmoureaux merged 1 commit into
longturn:masterfrom
Hyalunar:master
Oct 9, 2026
Merged

lmoureaux merged 1 commit into
longturn:masterfrom
Hyalunar:master

Conversation

@Hyalunar

@Hyalunar Hyalunar commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Perform the in fix discussed in #3017

The flag name for packet capability-dependence was probably mis-spelled because the name is so similar to the field-wise flag.

@lmoureaux lmoureaux linked an issue Oct 7, 2026 that may be closed by this pull request
@lmoureaux

Copy link
Copy Markdown
Contributor

Thank you!

Out of curiosity, what are you planning to do with the parser?
Do you think we could replace ours one day? (I've been refactoring it a lot but it's still not great.)

@Hyalunar

Hyalunar commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Thank you!

Out of curiosity, what are you planning to do with the parser? Do you think we could replace ours one day? (I've been refactoring it a lot but it's still not great.)

I was trying to stitch together a code-generator for the network protocol. I was hoping to be able to snoop into the communication for turn changes.

No offense intended, the one in the repo looked very scary and I didn't dare hack it. I've not gotten any further than parsing because I'm missing all the enum-declarations from C.

While I would feel honored to replace yours, it would probably not increase maintainability. Unless you prefer hacking someones Haskell code instead of python.

@Hyalunar

Hyalunar commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

I have put it up here, in case of further interest: https://gist.github.com/Hyalunar/1c0663e35f6ea77a3cc2d5795474d343

@lmoureaux

Copy link
Copy Markdown
Contributor

Thanks! I don't know how much info you want to gather about TC but it might be just a few packets, and in that case it's more efficient to write the decoder by hand.

@lmoureaux
lmoureaux enabled auto-merge (rebase) October 9, 2026 12:20
@lmoureaux
lmoureaux merged commit 693f89d into longturn:master Oct 9, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cap flag for packets in packet.def

2 participants