Open
Conversation
…(avoid storing whole json string in memory)
…sponse CSVs in memory
…d of creating a list and removing duplicates at the end
…; io import no longer needed
…g; need to re-import io and csv
…ead of constructing whole string in memory
…teration, instead of storing the whole list in memory
becky-gilbert
commented
Apr 3, 2026
| # Assumes n_previews fit on one page | ||
| self.assertEqual(n_matches, self.n_previews) | ||
|
|
||
| def _get_psychds_zip(self, query_string=""): |
Contributor
Author
There was a problem hiding this comment.
@bleonar5 I was worried about modifying the content in psychds downloads, so I added some tests (starting here) to check that it's still correct. Can you let me know what you think, and if I should add any others? I want to make sure that I'm not missing any edge cases.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1599
We've had a number of problems with data downloads timing out recently. This PR attempts to fix those issues by streaming to/from temp files, rather than concatenating very large strings that are fully stored in memory.
The temp files created with
tempfile.NamedTemporaryFilewill be deleted automatically. There a few places that use thedelete=Falseargument because the data needs to be read back in later - these are cleaned up via atry/finallyblock, but we may need to check periodically to make sure that they do not persist if/when a download request fails.Also, these changes reduce the peak memory usage, but there might still be issues with the response taking too long and hitting the response timeout. So if the problems continue, then we may need to turn some of the large/slow downloads into async tasks.
This PR also adds tests for the PsychDS zip file contents.