refactor(core/desktop): L3 as L2-row vertical split lines (#85) - #91
Merged
Merged
Conversation
Primary L3 state is ordered interior splits; measures derive from L2 bounds + splits. Desktop L3 edit drags/adds/deletes split lines; measure boxes are read-only derived. Add split metrics aliases and migration helpers.
8 tasks
measureRectsFromStructure ignored kind=measure_derived, so dual-view highlights fell back to OCR tiles and missed split lines. Also prefer structureDraft so highlights track edited splits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor L3 from free measure rectangles to ordered vertical split lines on each L2 row (#85).
Core
SplitLine+splits_to_measures/measures_to_splits/ move-insert-deletesplits; measures =[L2.x1, .splits, L2.x2]id/source/editablesplit_count_mae,split_mean_abs_x_error)Desktop
layers.L3.splitsDocs
docs/l3-split-model.mdTest plan
pytest tests/test_l3_splits.py+ structure/L3/rerun suitestsc --noEmitCloses #85