Add optional yesterday BG comparison line to main graph#665
Merged
Conversation
Adds a Graph Settings toggle (Nightscout only) that overlays yesterday's BG curve on the main graph, time-shifted by 24h so it aligns with the same clock time today. Drawn as a thin dimmed gray line with no dots, purely for comparison. When enabled, one extra day of history is fetched and the overlay is capped to now plus the configured hours of prediction so it never extends further into the future than the prediction line.
…omparison-line # Conflicts: # LoopFollow/Controllers/Graphs.swift # LoopFollow/Settings/GraphSettingsView.swift
…omparison-line # Conflicts: # LoopFollow/Controllers/Nightscout/BGData.swift
marionbarker
approved these changes
Jun 14, 2026
marionbarker
left a comment
marionbarker
left a comment
Collaborator
There was a problem hiding this comment.
Test with iOS 18 and iOS 26 phones and using Loop and Trio URLs.
Show yesterday's BG works for both URLs.
marionbarker
pushed a commit
that referenced
this pull request
Jun 21, 2026
Adds a Graph Settings toggle (Nightscout only) that overlays yesterday's BG curve on the main graph, time-shifted by 24h so it aligns with the same clock time today. Drawn as a thin dimmed gray line with no dots, purely for comparison. When enabled, one extra day of history is fetched and the overlay is capped to now plus the configured hours of prediction so it never extends further into the future than the prediction line.
bjorkert
added a commit
that referenced
this pull request
Jul 10, 2026
Replace the danielgindi Charts CocoaPod with Apple Swift Charts across the app (minimum deployment target 16.6 -> 17.0): - New LoopFollow/Charts/: BGChartModel (chart data, rebuilt once per refresh cycle), BGChartView (main + small overview chart), BGChartStubs (shims for the legacy update*Graph() call sites) - Main chart interaction: content is laid out once per data/zoom change onto a wide canvas; panning is a pure offset transform with momentum, pinch zooms with a live preview committed on a geometric grid, double-tap cycles zoom presets, tap selects marks, hold-and-drag scrubs a selection - Follow-latest keeps "now" at 70% of the window, pauses while navigating history and returns after 5 idle minutes; jump-to-now button when paused - BG line renders one series per color run; marks are sliced to a render window around the viewport - Stats charts (AGP/TIR/GRI + stats pie) migrated to Swift Charts - Preserves cone of uncertainty (#605), yesterday BG line (#665), backend-specific override/temp target colors (#668), BG display clamp (#600)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional comparison overlay that draws yesterday's BG curve on the main graph, time-shifted by 24h so it lines up with the same clock time today. It's a thin, dimmed gray "ghost" line (no dots, no tap popups) purely for visual comparison of how the day is tracking versus the day before.
Details
bgData) is unchanged, while the full set — shifted +24h — feeds the overlay.Notes