Mark scheduled runs with nothing to build as cancelled instead of successful#705
Open
bjorkert wants to merge 1 commit into
Open
Mark scheduled runs with nothing to build as cancelled instead of successful#705bjorkert wants to merge 1 commit into
bjorkert wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled weekly run checks for new commits and only builds when something changed (or when the monthly forced build is due). When there is nothing to build, the build jobs are skipped and the run still completes with a green check — indistinguishable at a glance from a successful build. Users who rely on the green status can believe they have a fresh build even when their last real build attempt failed.
Change
A new
cancel_when_no_buildjob inbuild_LoopFollow.ymlfires only on scheduled runs where the build gate is false (no new commits and no monthly build due) and cancels its own run, so it shows as cancelled (grey) instead of successful.Status semantics after this change:
Details:
workflow_dispatch) runs always build and are unaffected.check_certs/buildgate restricted toscheduleevents, so it can never fire alongside a build.GITHUB_TOKENwith job-levelactions: write— no new secrets and no third-party actions. The trailingsleepkeeps the job alive until the cancellation lands, so the run cannot complete as successful first.SCHEDULED_SYNC/SCHEDULED_BUILDset tofalsealso see cancelled instead of green on scheduled runs, consistent with green meaning "built".fastlane/testflight.mdis updated to describe the new cancelled status, and its stale schedule description is corrected (checks run on Sundays with the forced monthly build on the second Sunday; the text still said Wednesdays / first of the month).