OmniTests: faultEventTimeSinceActivation is nil for 0x0000 fault time#106
Open
loopkitdev wants to merge 1 commit into
Open
OmniTests: faultEventTimeSinceActivation is nil for 0x0000 fault time#106loopkitdev wants to merge 1 commit into
loopkitdev wants to merge 1 commit into
Conversation
f6d56f9 made DetailedStatus return nil (not 0.0) when the fault time is 0x0000, a DASH reset-fault sentinel rather than a valid time. Update the two tests still asserting 0.0 (testPodInfoNoFaultAlerts, testPodInfoDuringPriming) to XCTAssertNil, matching the intended behavior.
itsmojo
approved these changes
Jul 8, 2026
itsmojo
left a comment
itsmojo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for updating the unit tests -- I should testing this out for myself.
Note that both 0x0000 and 0xffff fault times are reset-fault sentinels (0x0000 for DASH and 0xffff for Eros and O5). In the future we could expand the testing with different example reset-fault test cases for different pod types. But the current comments are sufficient with the current unit tests that are apparently using DASH reset-fault examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to f6d56f9 ("Properly handle and display times for DASH reset type pod faults"), which made
DetailedStatus.faultEventTimeSinceActivationreturnnilwhen the raw fault time is0x0000(a DASH reset-fault sentinel) instead of0.0. Two existing OmniTests still asserted0.0and now fail:testPodInfoNoFaultAlertstestPodInfoDuringPrimingThis updates both to
XCTAssertNil(...), matching the intended behavior (and consistent with the already-updated reset-fault test). This was blocking LoopKit/LoopWorkspace next-dev CI.