Skip to content

test(control-plane): preserve heartbeat and wait recovery read checks #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 3 commits into from
Oct 7, 2026
Merged

test(control-plane): preserve heartbeat and wait recovery read checks #5873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a2cebb
test(control-plane): adopt canonical Todo read contracts
hhyykk Oct 7, 2026
147bacc
test(control-plane): qualify read contracts with current Monitor owner
hhyykk Oct 7, 2026
af08364
test(control-plane): defer shared Todo assertions to current owner
hhyykk Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/control_plane/test_heartbeat_registry_route.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,12 @@ def test_cli_generated_guard_selection_and_settlement_ignore_conflicting_cwd_reg
code, guard = _execute(shlex.split(selection.replace("{todo_id}", cli.TODO_ID))[1:], project)
assert code == 0, guard
assert guard["selected_todo"]["todo_id"] == cli.TODO_ID
assert any(read["kind"] == "agent_preferences" for read in guard["required_reads"])
work_context = guard["interaction_contract"]["agent_channel"]["work_context"]
preference = next(source for source in work_context["sources"]
if source.get("kind") == "agent_preferences")
assert preference["content"]["current"]["items"][0]["statement"] == "Use the designated reviewer."
assert not any(read.get("kind") == "agent_preferences"
for read in guard["interaction_contract"]["agent_channel"]["required_reads"])
identity = guard["heartbeat_receipt"]["settlement_identity"]
# A later no-argument reentry must retain the original choice and authority.
code, guard = _execute(guard_argv, project)
Expand Down
4 changes: 2 additions & 2 deletions tests/test_quota_bound_wait_recovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def cli(*args: str, cwd: Path = project) -> tuple[int, dict]:
assert rc == 0 and guard["should_run"] is True, guard
rc, original = cli("todo", "list", "--goal-id", GOAL_ID, "--todo-id", TODO_ID)
assert rc == 0, original
digest = original["todos"][0]["completion_validation_sha256"]
digest = original["todo"]["completion_validation_sha256"]
rc, wait = cli(
"todo",
"update",
Expand Down Expand Up @@ -273,7 +273,7 @@ def cli(*args: str, cwd: Path = project) -> tuple[int, dict]:
assert _spend_run_count(runtime) == 0
rc, after = cli("todo", "list", "--goal-id", GOAL_ID, "--todo-id", TODO_ID)
assert rc == 0, after
todo = after["todos"][0]
todo = after["todo"]
assert todo["status"] == "open" and todo["resume_ready"] is False
assert todo["resume_when"] == f"{kind}:{MONITOR_ID}"
assert todo["completion_validation_sha256"] == digest
Expand Down
Loading