Repository navigation
docs(control-plane): reconcile current migration delivery checkpoint - #5875
Conversation
Signed-off-by: hyk <4408344+hhyykk@users.noreply.github.com>
hhyykk
left a comment
There was a problem hiding this comment.
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · ultra
动机
维护者在规划 TypeScript 迁移、Goal 存储切换和旧写入路径退役时,会读取这四份中英文当前检查点。
此前当前计划仍要求审完已经合并的 preflight 与创建恢复 PR,并把新 Goal 设置说成仅选择晋升后的目标;按此安排会重复实现创建 owner,推迟真正欠缺的安装态验证。现在读者能看到合并事实、源码中新 Goal 的 SQLite/hard_lease 候选,以及仍须逐项验收的出口。
本 PR 只纠正两份 RFC 和两份退役节奏文档的当前事实、链接与执行次序;代码路径、已安装行为和发布决策没有改变。
本次不认证安装采用、存量 Goal 迁移、完整共享 Goal 意图、旧策略和 writer 退役、D2/D3 或发布默认值。
后续仍由既有 R5/D1–D3/T0–T4 owner 完成安装态恢复和调用方读回、策略迁移、最后调用方删除及持续运行资格;本 PR 是可独立核对和回退的文档检查点。
改动思路
以 main 06b6caa07b3a7e420584f36c23320e173cddd1b8 的源码和合并记录为权威,复用 goal_storage.py 的机器设置、local_authority_defaults.ts 的目标解析及 new_goal_initialization.ts 的原操作回执;文档只投影这些事实。做不了这次修订会继续误导维护者去关闭已合并队列。更小的单语或单文件改法会留下另一份当前指令相互矛盾。正向路径是维护者从任一语言 RFC 进入现行节奏,找到实际 owner 和下一个安装态验证包;反向路径是显式 v0、v1 canonical_creation=false 或存量 Goal,仍按原选择处理,不从“源码候选默认”推断发布或迁移。#5598 与 #4061 改动的是 RFC 其他段落,当前四份文档的修订范围没有覆盖它们的 hunk。
具体改动
关键内容讲解
typescript-control-plane-migration-v0.md:刷新英文当前边界、保留旧入站锚点,说明 #5500/#5805 的新建与重试归属,并将尾部“默认 SQLite 待完成”限定为发布默认资格。typescript-control-plane-migration-v0.zh-CN.md:同步相同的合并、配置和未完成资格事实;保留旧中文锚点。2026-09-28-retirement-cadence.md:把 #5283/#5500/#5805/#5308/#5398 归入已合并基线,替换过期的待合并队列和“仅晋升目标”任务,继续区分安装态、策略与 writer 退出。2026-09-28-retirement-cadence.zh-CN.md:同步英文节奏表、历史清单标注、配置关闭语义和交付包。
验收依据:docs/architecture/rfcs/typescript-control-plane-migration-v0.md; docs/architecture/rfcs/shared-goal-authority-state-provider-v0.md,基线修订 06b6caa07b3a7e420584f36c23320e173cddd1b8。T0 的当前合并事实在本次文档检查点得到核对,但完整调用方矩阵和实现验收仍由既有 T0 owner 完成;T3 的全部消费者收口、T4 的最后真实调用方及适用切换验收仍由既有 owner 处理;已证明无消费者的内部路径可随实现删除;D2 的持续运行和 D3 的安装态迁移/回退仍是独立验收,不因合并或源码默认而通过。对旧标题链接的显式锚点及新配置链接做了本地解析;历史资格段落没有进入改动 hunk。
对主干的风险
最强反例是把未配置新 Goal 的源码 SQLite 默认误读为已经安装采用或可以发布默认值:触发点在 RFC 当前边界,后果会是跳过备份、带新写入回退或长期负载验证。改动后的四份文档均把“源码候选”和 D2/D3/发布默认分开,配置参考也要求显式关闭并保留存量选择。另一个负例是旧入站章节链接失效;旧锚点和新链接已逐一核对。精确差异只有四份文档,共 +81/-45,git diff --check 通过;主线程提供的同一 head canary 记录为 3 项直接检查及 19 项选中检查通过,公共边界检查四个文档路径无命中。这里没有重跑安装态或持续运行验证,不能据此提升资格;初次缺少 npm 依赖是环境准备失败,修复依赖后记录的通过不证明历史冷 CLI 失败根因。
我的整体评价
结论:APPROVE,精确 head 136299143b1348bc53225fde51305151120ebe5f。这份文档增量让长期工作优先追踪真实未完成的安装态和退役验收,并减少读者按过期队列重复操作;普通 CLI/App/Lark 使用路径没有代码变化。没有新增状态词汇、协议、权限或默认行为,旧锚点是唯一需要保留的文档兼容边界。相关小型未来重构检查已落在现有四份文档内:压缩过期当前说明并复用已有 owner,不需要新文档或 helper。剩余风险是之后的安装态与 D2/D3 证据尚未取得,GitHub CI 在观察时仍排队;合并准备状态由维护者另行核对。
English verdict: APPROVE for exact head 136299143b1348bc53225fde51305151120ebe5f. Four EN/ZH docs now match merged owners and the source new-Goal candidate; installed adoption, D2/D3, and release-default qualification remain open. Diff/link/source checks passed; remote CI was queued at observation.
loopx-agent
left a comment
There was a problem hiding this comment.
Approval conclusion
Exact head: 136299143b1348bc53225fde51305151120ebe5f; full base: 06b6caa07b3a7e420584f36c23320e173cddd1b8.
动机
旧 checkpoint 会让维护者重做已合并的 preflight 和创建修复,并把已有的新 Goal 默认创建当作尚未实现。本 PR 同步两种语言的当前事实,并保留安装/发布资格的独立验收。
A maintainer choosing the next migration or adoption task from the bilingual RFC and retirement ledger encounters this problem.
Before: the current plan sent maintainers back to merged preflight and creation work and described the storage setting as target-only; after: it identifies the merged owners and sends remaining work to installed recovery, adoption and writer retirement.
The exact head gives the same current frontier in both languages, preserves old inbound anchors and keeps source implementation separate from installed and release qualification.
This documentation review does not certify installed adoption, D2/D3, a released default, sustained performance or full TypeScript migration.
改动思路
四份现有文档替换过期 current queue/default 描述,并保留四个旧 HTML fragment。运行时无修改:已有 TS initialization/configuration owner 保持,v0 与 canonical_creation=false 是 target-only,存量选择 pinned。移除偏好是 reset 到源码候选默认,不是关闭创建。
Current source, installed adoption and release/default qualification remain separate. This is reconciliation in the existing owners, not a new roadmap or decision source.
spec_ref: docs/architecture/rfcs/typescript-control-plane-migration-v0.md
spec_revision: 06b6caa07b3a7e420584f36c23320e173cddd1b8
Semantic mirror: The Chinese and English RFCs carry the same scope and acceptance meaning. Implemented; bilingual changed-clause review / 123 relative links.Current delivery frontier: Reconcile existing owners; storage migration, policy retirement and installed adoption retain separate receipts and exits. Implemented; 7 merged primary-source records and base ancestry; actual unchanged default owner.One reusable validation matrix: Installed qualification, historical failed rows and independent retirement boundaries remain intact. Implemented; frozen section byte comparisons and unchanged qualification lines.
具体改动
RFC frontier → retirement ledger ordered packages → configuration/disable reference. Independently read machine_configuration/goal_storage.py and coordination/local_authority_defaults.ts: unconfigured new Goals select canonical SQLite/hard_lease; false/v0 retain post-promotion target semantics; retries preserve original creation and existing selection. Both language clauses carry the same source-versus-installed limits.
历史 September 28 清单明确标为当时状态,不能当作当前队列。D2/D3、policy migration、旧 writer 删除、installed rollback 和 release-default 保留自己的 receipt 和出口。
对主干的风险
Primary GitHub merge records and git ancestry verified for #5413/#5466/#5283/#5500/#5805/#5308/#5398 against the full base. All seven are merged ancestors with matching cited OIDs. Four-file link check validated 123 relative links and all four old inbound anchors. Frozen EN/CN installed-delegation and reusable validation-matrix sections are byte-identical; aggressive qualification and ten-day/100k lines remain unchanged.
Current default-owner and test blobs are identical across base and both PRs; 52 isolated real-CLI/bootstrap tests pass, including false/v0, reset/unconfigured, retry and existing selection retention. Exact-head standard premerge: 3 direct + 19 selected checks, no failed/skipped checks or manual holds. Public/private boundary scan passed. A reviewer link probe initially required files only; accepting an existing valid Markdown directory link corrected the probe. Hosted CI and installed/sustained qualification were not tested or claimed.
我的整体评价
No blocking finding on this exact head. The current frontier is accurate and bilingual; this bounded documentation outcome is complete while installed consumer adoption, D2/D3 and release-default qualification remain open. Future-facing pass applied: compress stale current statements in existing owners and keep compatible historical links. No new helper or parallel plan; no runtime/frontend/Lark/CLI implementation changes.
评审通过不等于更广的迁移、性能或发布资格通过;冻结门槛没有因已合并而放宽。
English verdict: APPROVE
Reviewer: model_agent; declaration_source=runtime_reported; model=gpt-6.1-sol; provider=OpenAI; reasoning_effort=xhigh; execution_observation_id=83fd2e1b85943200c010fdd3445f9af18cad56c1f4cb97a0ffd217e54f22c9a9.
The current TypeScript migration frontier and R5 retirement cadence still described merged preflight/creation recovery work as pending and the Goal storage setting as post-promotion-only. Reconcile both English/Chinese documents at main
06b6caa07: #5283/#5308/#5398/#5500/#5805 are merged, and the existing typed initialization/configuration owner already creates canonical SQLite/hard_leasefor unconfigured new Goals.Preserve v0 and explicit disabled behavior, existing Goal selections, historical qualification evidence and old inbound section anchors. Keep installed recovery/adoption, policy/writer retirement, full shared Goal intent, D2/D3 and release-default qualification as separate remaining outcomes. This removes obsolete queue instructions rather than creating another roadmap or decision owner.
Validation: merged PR metadata and ancestry verified; changed local links/anchors and bilingual facts checked; frozen qualification sections unchanged; four-file public boundary check clean. Current-main exact-head premerge passed 3 direct + 19 selected checks with no failures, skips or manual holds. The initial run lacked the TypeScript development dependency; installing the existing lockfile dependencies resolved that environment failure without source or budget changes. No runtime, frontend/Lark/CLI implementation or installed behavior changes. Hosted CI and broader migration qualification are not claimed.
Related refactor pass: compressed stale current queue/default statements in their existing owners and retained compatible historical links. No new helper, fixture or parallel planning document.