Skip to content

fix(materials): revise existing candidates after exact reads #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopx-agent merged 2 commits into from
Oct 8, 2026
Merged

fix(materials): revise existing candidates after exact reads #5934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fcbea4
fix(materials): revise existing candidates without duplicate intake
loopx-agent Oct 8, 2026
3110eee
fix(material): validate retained snapshot before revision staging
loopx-agent Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions loopx/capabilities/material_lifecycle/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,30 @@ Ordinary one-off reading, summarization, or web research does not require this
capability unless the project has explicitly activated a managed material
store.

## Revising An Existing Candidate

When a short preview is later fully read, revise the existing candidate instead
of adding a duplicate. `build_material_candidate_revision_proposal` binds the
current authority revision, previous record reference, replacement record
reference and exact-read content digest. `apply_material_candidate_revision`
uses the existing source owner's authorization, immutable staging, readback and
CAS; `rollback_material_candidate_revision` restores the previous authority
only while the applied revision is still current.

The source implements `MaterialCandidateRevisionProvider` beside its existing
intake methods. Reconciliation must preserve all stable identities, record
counts, other records, lifecycle states, rankings and previous content. A
revision cannot reactivate an archive. Metadata changes must be bound by the
replacement record reference; source adapters must invalidate public-field
reviews that no longer match the revised record/content. Ranking changes still
use a separate Decision Context-backed settlement and receipt.

This extends the existing Python material source apply boundary, without a new
authority, scheduler, ranking policy or generic CLI writer. An SDK proposal
does not authorize a write. Product/project adapters must expose the operation,
publish the readable queues, persist receipts and verify their readback before
reporting the user's workflow complete. Existing intake stays append-only.

## Single-Material Reranking

`plan_material_single_move(ordered_material_refs, material_ref, to_rank)`
Expand Down
18 changes: 18 additions & 0 deletions loopx/capabilities/material_lifecycle/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,26 @@
MATERIAL_INTAKE_RANKING_SETTLEMENT_SCHEMA_VERSION,
build_material_intake_ranking_settlement,
)
from .revision import (
MATERIAL_CANDIDATE_REVISION_APPLY_RECEIPT_SCHEMA_VERSION,
MATERIAL_CANDIDATE_REVISION_PROPOSAL_SCHEMA_VERSION,
MATERIAL_CANDIDATE_REVISION_ROLLBACK_RECEIPT_SCHEMA_VERSION,
MaterialCandidateRevisionProvider,
MaterialCandidateRevisionReconciliation,
apply_material_candidate_revision,
build_material_candidate_revision_proposal,
rollback_material_candidate_revision,
)

__all__ = [
"MATERIAL_CANDIDATE_REVISION_APPLY_RECEIPT_SCHEMA_VERSION",
"MATERIAL_CANDIDATE_REVISION_PROPOSAL_SCHEMA_VERSION",
"MATERIAL_CANDIDATE_REVISION_ROLLBACK_RECEIPT_SCHEMA_VERSION",
"MaterialCandidateRevisionProvider",
"MaterialCandidateRevisionReconciliation",
"apply_material_candidate_revision",
"build_material_candidate_revision_proposal",
"rollback_material_candidate_revision",
"MaterialProjectScope",
"MaterialProjectScopeVerifier",
"MATERIAL_CANDIDATE_INTAKE_APPLY_RECEIPT_SCHEMA_VERSION",
Expand Down
Loading
Loading