Skip to content

fix(turn-contract): hash canonical LF bytes so the provenance guard is checkout-independent #6200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 1 commit into from
Oct 11, 2026
Merged

fix(turn-contract): hash canonical LF bytes so the provenance guard is checkout-independent #6200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/generate_turn_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,11 @@ def require(condition, message):

def build_artifacts():
contract = validate_contract(read_contract())
digest = hashlib.sha256(CONTRACT_PATH.read_bytes()).hexdigest()
# Git may check the contract out with CRLF on Windows; hash the canonical LF
# bytes so every checkout records the same provenance digest.
digest = hashlib.sha256(
CONTRACT_PATH.read_bytes().replace(b"\r\n", b"\n")
).hexdigest()
header = f"Generated by scripts/generate_turn_contract.py; do not edit.\nSource: loopx/control_plane/turn_loop_controller_contract_v0.json\nSHA256: {digest}"
py = [
'"""' + header + '"""',
Expand Down
12 changes: 12 additions & 0 deletions tests/architecture/test_turn_contract_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,18 @@ def test_generator_check_is_deterministic_and_does_not_repair(tmp_path, monkeypa
assert path.read_text() == "stale\n"


def test_contract_digest_ignores_checkout_line_endings(tmp_path, monkeypatch):
# A Windows checkout may still carry CRLF when the guard reads the contract.
crlf_contract = tmp_path / generator.CONTRACT_PATH.name
contract_text = generator.CONTRACT_PATH.read_text(encoding="utf-8")
crlf_contract.write_bytes(contract_text.replace("\n", "\r\n").encode("utf-8"))
monkeypatch.setattr(generator, "CONTRACT_PATH", crlf_contract)
assert generator.build_artifacts() == {
generator.PYTHON_PATH: generator.PYTHON_PATH.read_text(encoding="utf-8"),
generator.TYPESCRIPT_PATH: generator.TYPESCRIPT_PATH.read_text(encoding="utf-8"),
}


def test_typescript_settlement_reexports_generated_result_set():
result = subprocess.run(
[
Expand Down
Loading