Repository navigation
fix(app): show published research source and original review deadline - #6266
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent | gpt-6.1-sol | OpenAI | runtime_reported | xhigh
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
APPROVE — 精确 head c0a4f824551b52b199bceacc302a39cf877d4cf6,未发现阻断问题。
动机
研究成果阅读者需要核对结论来自哪次发布,以及何时必须重新复核。
基线只展示 schema、发布时间和哈希,缺少来源与原期限;候选保留来源编号、版本、替代来源和原复核期限,期限错配时清除正文。
实际打包页面核验了原来源和期限、键盘展开、手机布局,以及期限错配拒绝和恢复后的重新读回。
本次为既有 Goal 研究成果的只读来源展示,不授予研究计算、账户、交易或方法晋升权限。
改动思路
复用既有 TypeScript 投影 envelope 与 Goal 成果 renderer;Core 持续拥有生命周期、哈希和公共读取校验。 这个有界切片交付已有持久发布的来源和原期限读回,不新增配置或持久化格式。 本地显示状态从既有事实派生,操作和持久化 owner 保持原处;不添加权限、后台 provider 或新的配置。需要的判断与观察阶段分开:真实 owner 的拒绝或读回是依据,提示、折叠和页面可见性不能代替完成或验收。失败后继续由已有负责人或刷新流程恢复。
具体改动
完整4文件覆盖 envelope 数据、Goal 成果装载、共享来源卡片和聚焦验证。装载不再只留 view,而把已有 envelope 同时传给 renderer;原 Goal、扩展和 surface、schema、revision、hash 与来源编号、正整数版本、supersedes 放在原生 details 中,原发布时间和复核期限始终可见。缺失或非法已知 lineage 字段显示未知,空 supersedes 显示无;不从正文推导来源。fetch 在原身份检查上同时比对两项时间。实际期限错配刷新清除研究正文,原 catalog 时间保持,恢复传输后同一次有界刷新可重新显示原来源。
关键代码讲解
publishedResearchLineage:Read known optional lineage from envelope;复用原投影与错误恢复 owner,不创建持久字段。fetchPresentationProjection:Bind all response identity fields including clocks;复用原投影与错误恢复 owner,不创建持久字段。GoalResearchResults load:Retain full envelope and clear previous contents before refresh;复用原投影与错误恢复 owner,不创建持久字段。
规格映射:docs/reference/extensions.md,spec_revision 43173c0b8c8761abee4cdddc665f0f0f20f194f7,判据 revision-bound-read, original-publication, display-not-authority, unknown-not-inferred 均 implemented;基线契约在实现前读取,当前文档增补不被用来倒推验收标准。
对主干的风险
独立通过 schema smoke、source-period/来源 coverage、packaged research-results 的失效/错误 Goal/disabled/owner-only/恢复场景、Core lifecycle smoke、正常 bundle build/source verify、CSS 与 diff。真实隔离 Core install/doctor/publish/readback 与 Ego 打包页显示来源1、替代来源和原 Jan/Feb 时钟;基线接受被改为2099的 detail deadline,候选拒绝并移除正文,恢复原传输后重新读取。手机390px无横向溢出,原生 disclosure 用 Enter 展开且焦点可见。
语义与 CI 对齐
先执行 changed-diff semantic advisory,再完整 semantic-vocabulary-drift smoke,既有45处 unresolved producer 保留;空 probe 不覆盖动态构造/TSX,也不证明语义。复用既有 vocabulary,新增解读留在本地投影。CI 未查询、轮询或等待。一次性 helper 配置错误和 Ego 手机导航恢复均保留,没有把作者的测试当作本轮执行。真实 Core 使用合成 provider/数据,期限损坏为响应层故障注入;不声称测试了真实财务源、账户或本机安装。
我的整体评价
长期继续路径改善,用户体验改善:实际打包页面核验了原来源和期限、键盘展开、手机布局,以及期限错配拒绝和恢复后的重新读回。 复用既有 TypeScript 投影 envelope 与 Goal 成果 renderer;Core 持续拥有生命周期、哈希和公共读取校验。 这个有界切片交付已有持久发布的来源和原期限读回,不新增配置或持久化格式。 future-facing pass 已复用完整 envelope 并集中已知 lineage 解析,不需要第二个来源 DTO 或迁移层。 范围与成本相称,兼容旧 envelope 的可选 lineage 和 nullable deadline;已安装行为、真人模型/真实 provider 与更广路线图未验证。批准当前有界精确 head;平台/Code Owner与维护者合并权限另行读回,本评审不执行 merge。
English verdict: APPROVE
|
Reviewer: model_agent | gpt-6.1-sol | OpenAI | runtime_reported | xhigh English verdict: APPROVE Exact head Goal Results retains the existing sealed envelope,displays original publication/review clocks and exposes source/version/supersedes through keyboard-native details. Missing/malformed lineage is unknown,never guessed. Real isolated Core publication/store/HTTP and packaged Ego UI were exercised. Baseline accepts a transport-altered deadline;this head rejects and clears the research body,then recovers the original publication after restoration.390px has no horizontal overflow. Disabled,owner-only,wrong-Goal and stale recovery paths pass. Independent schema,source-period/provenance coverage,packaged research negatives/recovery and Core lifecycle smoke passed. Normal build/source verification,CSS,diff and semantic checks passed;changed-diff advisory preceded full smoke,45existing unresolved producer sites remain. Disposable helper/setup/selector failures are retained and corrected without product changes or weakened assertions. Synthetic fixtures and response-only faults do not qualify installed behavior,live models or real finance/account sources. CI was not queried,polled or awaited. Specification: |
Goal And Delivered Outcome
Published Goal research currently loses the resolved envelope after fetching its view. Owners can see “review_due” but cannot inspect the source/version, superseded sources or exact original deadline in App.
This change retains the verified envelope, displays publication and review times, and places source identity/version, supersedes and the exact reference in a keyboard-accessible disclosure. Missing or malformed lineage stays unknown. The detail reader rejects publication/review clocks that disagree with the requested index, alongside its existing Goal/revision/hash checks.
Basis: an accepted caller/display repair; extends the existing result path delivered by #5575. Base: main.
Author Declaration
Written by: OpenAI Codex, GPT-6 family model agent.
Implemented against
docs/state-interaction-model.mdcheckpointed/content-addressed projection contracts anddocs/development/design.md/docs/development/frontend-delivery.md, baseline43173c0b8c8761abee4cdddc665f0f0f20f194f7.fetchPresentationProjection; wrong Goal/hash/revision/time failures and recoveryDecisionResearchSurface; synthetic reference/legacy coverageScope And Continuation
Four frontend/smoke files only. Core status/index, provider publication, calculation and card owners are unchanged. This is a candidate App repair: maintainer merge and the normal release/installed-caller adoption remain pending. No account action, external card delivery, historical-source qualification or financial utility is claimed.
Validation
Tested source:
c0a4f824551b52b199bceacc302a39cf877d4cf6. Run state: finished. Input classes: synthetic, public_fixture.git diff --checksmoke/decision-research-surface-coverage.tsx: source/version/supersedes, unknown lineage, hash/revision/Goal/clock mismatch, disabled/private refusal, recovery;npm run smoke:presentation-surface-schemauv run --extra test python scripts/chat_bundle.py build --installthenverify --source; final commit build verified separatelyexamples/semantic-vocabulary-drift-smoke.py;loopx check --scan-root .(public boundary clean)An initial SSR launch raced a dependency reinstall and was rerun after the build. The semantic generator’s obsolete
--checkinvocation was rejected; its documented semantic smoke passed. Build retains the existing large-chunk warning. Full workspace smoke sweep and live/default App installation were not run; the affected Goal-results journey was exercised directly. Private runtime evidence is retained locally and is not uploaded.Frontend / Visual Evidence
UI impact: changed. Public-fixture before/after screenshots captured from the baseline/head components with packaged styles and attached below. These component previews complement the real packaged-App/API journey; they do not establish backend adoption by themselves.
States verified: desktop and 390px mobile, Chinese/English, keyboard disclosure, populated/unknown, loading, rejected and disabled/recovery. Source data for publishable visuals: public synthetic fixture only.
Attention review: exact deadline remains visible for the owner’s review decision; technical identifiers move into one disclosure rather than occupying the main reading surface. Existing research and uncertainty stay prominent. No new hero/navigation or style system; no new raw colors. Private workspace screenshots are excluded.
Before (baseline component):
After (original clocks remain visible):
After (expanded source reference):
Type / Area
Shared-authority RFC fixture impact: N/A; this does not change authority, state schemas or runtime routing.
Boundary Checklist