Repository navigation
release: prepare 1.4.1 and complete command manual entries - #6492
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent; model=gpt-6.1-sol; provider=OpenAI; runtime_reported; reasoning_effort=xhigh
Approval conclusion (author-owned PR; GitHub blocks formal self-approval). Exact head f740f2b83a029b3f55b5b41976154c066f665b9c.
动机
准备安装和发布 1.4.1 的用户与维护者。发布前版本仍为 1.4.0,命令手册没有列出两个已经存在的命令,导致完整性检查拒绝发布。版本、手册和双语书籍统一到 1.4.1,已有命令在维护者目录中可发现,生成手册的完整性检查通过。这里只准备版本与命令目录;不执行新能力、不修改存储默认或权限,也不把后续发布资格和制品验证声明为完成。
改动思路
复用原有版本、命令目录与生成器:元数据定义版本,COMMAND_GROUPS 定义命令发现,render_manpage 生成安装手册。两个命令本来就注册在 CLI,本次只把它们补进已有的维护者目录,不把帮助可见解释为功能启用。现有 catalog、renderer 和版本 owner 已足够,不引入新状态、策略或兼容层。当前 PR 只对齐版本与命令发现;后续精确源码发布资格保持独立。原有默认帮助和两个命令的专用帮助保持逐字一致,不需要流程图来说明这次直接投影修复。
具体改动
依据 docs/product/release-readiness.md 在 a59aed703374040240f23b2e51ddaf209fcbacc4 的 Named Version Contract:版本 owner、canonical help、生成 manpage 和当前双语 Dev Book 必须在冻结前一致,本 head 已实现并经原生四项 smoke 验证。八个文件共22增8删;没有改动历史版本示例、首页首屏、状态/租约或任何命令执行逻辑。
关键代码讲解
loopx/__init__.py:5 的 __version__ 与 pyproject 一起从1.4.0升级到1.4.1,是 wheel/CLI 的原有身份源。loopx/help_surface.py:23 的 COMMAND_GROUPS 添加 goal-direction 与 zcode-goal 的 --help 行,说明显式配置、execute 和托管CLI会话范围。loopx/help_surface.py:568 的 render_manpage 本身未改,消费同一目录生成版本化手册,因此没有独立手写目录。中英文书籍的版本基线同步更新,不声称后续模型或制品资格已完成。
对主干的风险
最强反例是版本测试绿但手册仍遗漏 parser 命令,或读帮助意外启动执行。本次在不可变 base 与精确 head 上运行同一真实 CLI 比较:base 的完整目录检查因这两个漏项退出1,head退出0;默认帮助及两个专用帮助字节一致。原注册、权限和执行 handler 均未改,帮助输出不写状态。四项发布文档/包检查、Ruff、diff、八路径公开边界与精确质量验证均通过。按配置未查询PR CI;这些验证足以覆盖本补丁的身份和命令发现风险,不替代最终发布源码的全套资格。未引入新词表、默认开关、协议、存储或权限;类型、领域中立和义务规则边界均检查过。
我的整体评价
APPROVE,goal_achieved仅指版本与目录准备这一完整切片。long_horizon不适用:没有改执行或持续工作路径;user_experience改进:同一目录可以找到现有能力,不增加必经步骤。现有 catalog、renderer 和版本 owner 已足够,不引入新状态、策略或兼容层。当前 PR 只对齐版本与命令发现;后续精确源码发布资格保持独立。相关重构检查后保留现有单一owner,没有可删的重复知识或新增兼容层。公开发布、真实模型及安装器读回仍在后续流程,成功检查与此评审不单独授予merge权限;已有维护者授权只在readiness通过后使用。
English verdict: APPROVE at f740f2b83a029b3f55b5b41976154c066f665b9c. Version sources, generated manual and bilingual book anchors agree on1.4.1; two shipped commands now enter the existing catalog. Four focused smokes, immutable base/head CLI comparison, Ruff, diff/public-boundary and exact-scope quality pass. No execution, authority, default help or first-screen change; final release qualification remains separate.
Prepare the requested 1.4.1 patch release from the latest observed main snapshot. Package metadata, the generated manual and the bilingual developer-book anchors now agree on 1.4.1. The release documentation preflight exposed two unclassified shipped commands; the existing maintainer catalog now documents
goal-direction --helpandzcode-goal --help, so the generated manual covers every parser command.The scope is release identity and command discovery. There is no runtime execution, storage/default, authority, transport or first-screen presentation change. Existing commands retain their per-command opt-in and permission checks. The existing catalog and renderer remain the single help owner; no companion abstraction is needed.
Validation at this head: CLI help/manpage, developer-book publication, release version contract and release artifact smokes pass; Ruff and diff hygiene pass; public/private scan covers all eight changed files with zero errors/warnings; exact-scope change-quality receipt verifies valid. This focused set covers identity, catalog parity, generated bytes and documentation privacy. No PR CI was queried under the resolved maintainer policy. Subsequent release closeout at product4f27801c4: GitHub/PyPI packages, four desktop installers, signed Mac updates, desktop-stable, source stable and website are verified at1.4.1. Actual PyPI upgrade, source/hash/attestation, doctor and packaged UI readback passed. Fixture-only recovery6509/6510 preserved the product tag. The verified personal illustrated guide has two released UI images and reviewed native rendering; current document sharing permissions apply. See https://github.com/loopx-project/loopx/releases/tag/v1.4.1 and https://my.feishu.cn/docx/Qnzid7oeWojR3hxsV46cNr2wnHd .
Maintainer authorization covers the release delivery batch and admin bypass after exact-head public review, required validation and merge readiness.
Community Contributors
社区贡献者