Skip to content

test(chat): wire session recovery into amendment HTTP fixtures #6812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huangruiteng merged 2 commits into from
Oct 18, 2026
Merged

test(chat): wire session recovery into amendment HTTP fixtures #6812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82c64f2
test(chat): wire session recovery into amendment HTTP fixtures
loopx-agent Oct 18, 2026
6fa13c0
Merge branch 'main' into codex/ci-browser-input-20261018
huangruiteng Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/control_plane/test_chat_goal_amendment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@
import pytest

from test_goal_amendment_authority import source_goal, _root # noqa: F401
from loopx.chat_runtime import ChatRuntimeController
from loopx.chat_server import ChatHTTPServer, ChatRequestHandler
from loopx.chat_store import ChatSessionStore
from loopx.control_plane.effect_runtime import restart_effect_runtime


Expand All @@ -20,6 +22,11 @@ def api(source_goal, tmp_path): # noqa: F811 - pytest fixture imported above.
server.registry_path = source_goal["registry"]
server.runtime_root = source_goal["runtime"]
server.runtime_root_override = str(source_goal["runtime"])
server.chat_store = ChatSessionStore(source_goal["runtime"])
server.runtime_controller = ChatRuntimeController(
store=server.chat_store, codex_bin="unused-fixture-codex",
registry_path=source_goal["registry"],
)
server.selected_goal_id = source_goal["ref"]["goal_id"]
server.verbose = False
thread = threading.Thread(target=server.serve_forever, daemon=True)
Expand Down Expand Up @@ -47,6 +54,7 @@ def call(body=None, *, query=None, path=None, origin=None):
server.shutdown()
thread.join(5)
server.server_close()
server.runtime_controller.close()
restart_effect_runtime()


Expand Down
4 changes: 1 addition & 3 deletions tests/control_plane/test_chat_request_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
from test_goal_amendment_authority import source_goal as source_goal
from test_request_amendment_recovery import BRIEF
from loopx.capabilities.manager_context import deliver
from loopx.chat_store import ChatSessionStore


def _source(api):
call, f, server = api
store = ChatSessionStore(f["runtime"])
server.chat_store = store
store = server.chat_store
session = store.create_session(goal_id="loopx-manager", agent_id="codex", adapter_kind="codex_app_server",
upstream_thread_id="request-control-fixture", channel_id="manager")
turn, _ = store.create_turn(session["session_id"], client_turn_id="request-source", message="Check the current contract", origin="web")
Expand Down
Loading