Repository navigation
feat(benchmark): show source-bound retained outcome improvement - #6829
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The six process judgments do not show whether the retained native outcome improved. Add a separate Retained improvement / 已采用成果增量 metric, computed by the existing benchmark-toolkit TypeScript owner from an explicit baseline, native optimization direction and source-bound retention evidence.
Native error 7 → retained 3 displays +4 points. Rejecting a candidate with error 9 while retaining 7 displays 0, with candidate change −2 inside the disclosure. Missing baseline or adoption evidence stays unknown; actual adopted regressions remain negative. This is a provider-declared native comparison, not a composite score, objective completion or LoopX causal attribution.
comparisonextends the existing native-capture contract; omitting it preserves the prior projection shape and model analysis key. An archived submission time may explicitly remain null instead of inventing a clock. Known times retain calendar/window validation.benchmark-toolkit, providerloopx-core. Python remains the existing file/HTTP transport; it only admits the additional exact bound citation ranges. No solver, evaluator, scoring, authority-store, model dispatch default or installed App changes.Validation
mypy trajectory_assessment_store.pyprobe failed outside the documented profile, reporting 4,920 diagnostics across 582 imported files. It is retained as a failed probe, not treated as a passing check.Remaining integration and CI boundary
This PR supplies the analysis metric and per-Goal renderer. Fixed case-pack registration does not create a real experiment child Goal. The remaining experiment journey must use actual parent/child registration and run/source identities, with comparison at the parent and analysis in the corresponding child.
GitHub
kernel-static-checkscurrently fails the pinned top-level module budget: 147 modules against a limit of 145. Base3203b55843d2dcca5b77822ed857442adf944587and this head have the same 147 top-level Python modules; this PR adds none. The hard gate remains held; its budget is not increased to mask the failure. Other CI and exact-head review remain pending.Visual evidence
Tested source revision:
c01d3863cec14cfc21e05724d14212a72a922f2a. Actual packaged browser captures with synthetic input and a disposable deterministic analysis child; these images are not benchmark findings or installed-App evidence. The before renderer uses the same synthetic capture. Desktop is the initial 1716×980 viewport; mobile is the affected research section at 390×844 after scrolling. Native details and optional explanations are collapsed by default.Synthetic local preview (author machine): open packaged research overview.