Repository navigation
fix(cli): move upgrade helpers into the existing CLI package - #6830
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required kernel static check rejects current main because
loopx/*.pygrew from its pinned 145 files to 147 after the upgrade adapters were added. This blocks the invariant gate that precedes full Python qualification. Both new helpers have one production consumer,cli_commands/support_control_update.py; move them into that existing CLI package.UpdateProgressmoves byte for byte. The upgrade adapter changes only three relative-import levels; the caller and existing regression tests point to the new internal paths. No root compatibility wrapper is retained: these are undocumented implementation modules with no exported or persisted import contract, and the caller inventory found no other production consumer. Publicupdate/upgradecommands, output, installation ownership, prompt recovery and native App verification stay unchanged. The budget fixture and all original test assertions are unchanged.This is a separate main-based repair for the required-CI hold observed on #6828, rather than mixing updater placement into that performance proposal.
Natural hosted validation
The required kernel job passed on the unchanged author head
0f3964dd330194af4ddde20cc79bc449c00b044f. Its actual checkout was synthetic mergee0c051b6b05ab1bdc4a4c439394f809308e19e3b(base3203b5584); the complete Git tree is identical to the author tree. On Linux with Python 3.11.17 / Node 24.21, the original kernel command passed all 7 tests. The following File-authority suite passed 409 tests with no skips, and Ruff, mypy (17 files), and the CLI-output budget check all passed.This qualifies the repaired prerequisite on the real hosted path. The earlier #6828 run stays failed; this result does not qualify the full six Python shards, coverage/final gate, sustained costs, installed behavior or adoption into main.
Evidence
The exact original two-file kernel command was run from immutable source archives:
9a1b7f8a53203b5584d1f74e9bc0f3964dd330194af4ddde20cc79bc449c00b044fThe original required hosted failure remains failed. This repair does not raise its budget or waive it through baseline attribution.
79eb639d9b3c4e4613f1f92e26e6a7eab3a2c8f47ec71e47082feb1825afc70d. No quality safe-fix pass was needed. Signed commit, public-boundary scan, whitespace and bilingual checks passed.Standard goal-aware premerge passed at the unchanged head: four direct checks, Python compilation and eight selected canaries, including installation, packaged Codex CLI, updater, maintainability, semantic vocabulary and CLI-output checks. No failures or manual holds. Merge authority remains separate.
The bounded refactor places the helpers with their actual caller; it adds no capability, provider, state or new execution authority. No visual surface changes. Rollback is one commit revert. Independent exact-head review and the remaining natural hosted CI are pending; full six-shard/coverage/final/CI24 and installed-upgrade acceptance are not claimed.