Repository navigation
Check emitted pointers in initial-read deduplication coverage - #7930
Merged
Merged
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
The initial-reader coverage test must distinguish emitted pointers from logical selected facts. With #7914's recursive fact helper, a delivered parent also exposes its descendants to assertions, so the existing duplicate-child assertion fails even when that child was not transmitted separately. Check the original
selectionspointers instead. Current and peer requirements, deferred independent material and source-integrity assertions remain intact.Related: #7914. Intended base:
main. This is a test-oracle repair; production behavior is unchanged.Author Declaration
test_context_first_read.pyat the verified base.Self-check: inspected the helper and actual reader response; preserved all assertions and the original failing combination. No new abstraction, protocol field or runtime owner is needed.
Scope And Continuation
Complete within this test scope. The broader context proposals and their runtime/rollout acceptance remain with #7906, #7909, #7914 and #7923. The integration experiment is an isolated source combination, not an installed or merged delivery.
Validation
a965b9266b935d92ee9bc496333ce1a0bc6baeccfor the standalone proposal.tests/control_plane/test_context_first_read.py: 31 passed on this proposal4250a94aplus #7906cf520e9, #790982dc675, #79140605a55 and #7923d188b26: original assertion gives 535 passed / 1 failed / 46 unrun native opt-ins; only this oracle correction yields 536 passed / 46 unrun across the same 13 modules. The six affected production-source hashes are unchangedcqr_32d383ed3238dcdcc40everifies valid for base58a85d0aand heada965b926. The initial missing-receipt hold is retained as an earlier result; independent review and exact-head merge readiness are separateThe failure and the later corrected run are separate records. No CI was queried or manually triggered. Native binary, installed host, model outcomes and complete cost are outside this test-only change.
Frontend / Visual Evidence
UI impact: none. Screenshots, preview and viewport review: N/A; only an existing test assertion changes. Source data: synthetic/public fixtures.
Type Of Change / LoopX Area
Boundary Checklist