Skip to content

[run-tests] [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack#11

Closed
lordcheng10 wants to merge 5 commits intomasterfrom
fix_skip_entry_no_ack
Closed

[run-tests] [fix][broker] Fix the markdelete position does not move forward when isAutoSkipNonRecoverableData=true and individual ack#11
lordcheng10 wants to merge 5 commits intomasterfrom
fix_skip_entry_no_ack

Conversation

@lordcheng10
Copy link
Copy Markdown
Owner

This PR is for running tests for upstream PR apache#17751.

@lordcheng10 lordcheng10 reopened this Sep 21, 2022
lhotari and others added 5 commits September 21, 2022 15:58
…pache#17743)

- when setup is called explicitly, cleanup should be issued before it
- remove unnecessary "resetConfig" method calls
  - resetConfig gets called as part of internalCleanup
  - when resetConfig is in cleanup, it's possible to override config before calling setup
    - this allows using setup & cleanup methods instead of using
      error prone internalSetup and internalCleanup methods which might leave something behind
* fix entryFilter stats

* fix test

* add test comment

* review fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants