feat: add Reporter class for generating metric figures from CSVs - #35
Merged
Merged
Conversation
tcptrace is unmaintained. Replace the subprocess shell-out with pyshark.FileCapture, which wraps Wireshark's actively-maintained dissectors and exposes tcp.analysis.ack_rtt, tcp.analysis.retransmission, and per-stream packet grouping natively in Python. _FlowAccumulator tracks tx_packets, unique_bytes, rexmt_packets, timestamps, and RTT samples per flow direction. _dominant_flow() picks the flow with the most unique bytes. The 12-element metrics list is preserved unchanged for downstream compatibility. Update test_trace.py: replace exe_comm mocks with SimpleNamespace fake packets and pyshark.FileCapture mocks. Add _FlowAccumulator unit tests. 56 tests, 99% coverage. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…or bars Adds _plot_metric method that creates matplotlib figures with seaborn styling, plots metrics with confidence interval error bars, and saves to configured output directory. Includes validation of metric columns and lazy imports of plot libraries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Implements Reporter.plot() to iterate over metrics and CSVs, adds a __main__ CLI for generating PNG/SVG metric figures from the command line, and exports Reporter from the pcapprocessor package __init__. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reporterclass topcapprocessor/report.pythat reads tab-separated metric CSVs produced byMetricsWriterand generates one PNG/SVG figure per requested metricconfInt/2as half-width)Reporterviapcapprocessor/__init__.pyand as a runnable CLI (python -m pcapprocessor.report --csvs ... --metrics ... --output ... --format)Test Plan
_load_csvreturns correct column arrays and raisesFileNotFoundErrorfor missing files_plot_metriccreates PNG/SVG output, raisesValueErrorfor unknown metrics, uses metric name in filenameplot()creates one file per metric, auto-creates output directory, handles multiple protocolsReporterimportable from package top level🤖 Generated with Claude Code