Remove unused modulesByIds getter with type narrowing defect#130
Closed
Copilot wants to merge 1 commit into
Closed
Remove unused modulesByIds getter with type narrowing defect#130Copilot wants to merge 1 commit into
modulesByIds getter with type narrowing defect#130Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Fix performance issue for O(n*m) lookups and computations
Remove unused Mar 7, 2026
modulesByIds getter with type narrowing defect
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
modulesByIdsgetter used.filter(f => f)which fails to type-narrow, leaving the return type as(Module | undefined)[]instead ofModule[]. The getter was also never referenced outsidestore.ts.Changes
src/helpers/store.ts: Removed themodulesByIdsgetter entirely — dead code with no callers in the codebase.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.