Sem map/join: provenance + stable sqlite path + idempotent seed#237
Open
Areeb29 wants to merge 1 commit into
Open
Sem map/join: provenance + stable sqlite path + idempotent seed#237Areeb29 wants to merge 1 commit into
Areeb29 wants to merge 1 commit into
Conversation
Author
|
Push sem mp sem join |
Collaborator
harshitgupta412
left a comment
harshitgupta412
left a comment
There was a problem hiding this comment.
Please add description of the changes done in PR description. Also, please refrain from doing changes like comment deletion, variable renaming unless necessary.
| ) -> SemanticJoinOutput: | ||
| """ | ||
| Joins two pandas Series using a language model based on semantic similarity. | ||
|
|
Collaborator
There was a problem hiding this comment.
please revert this deletion
| ) | ||
|
|
||
| if return_provenance: | ||
| if provenance_left_col in joined_df.columns or provenance_right_col in joined_df.columns: |
Collaborator
There was a problem hiding this comment.
this should be checked before running the actual operation. Same applies for sem_map as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essential Elements of an Effective PR Description Checklist
README.mdandexamplesfor new features.PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS ABOVE HAVE BEEN CONSIDERED.
Purpose
Test Plan
Test Results
(Optional) Documentation Update
Type of Change
Checklist
BEFORE SUBMITTING, PLEASE READ https://github.com/lotus-data/lotus/blob/main/CONTRIBUTING.md
anything written below this line will be removed by GitHub Actions