Guard storage access for delivery readiness#1
Open
love19870821 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
localStorageis unavailable or restricted so the app remains usable.Description
isStorageAvailable()which safely testslocalStorageby attempting a set/remove and returns a boolean.loadEntries()to return an empty list when storage is unavailable and setspeechStatusto a helpful message, and keeploadEntries()JSON parsing inside atry/catch.saveEntries()to no-op when storage is unavailable and show aspeechStatusmessage on write failure.Testing
python -m http.server 8000and ran a Playwright script that opened the page and producedartifacts/voice-ledger-final.png, and the script completed successfully.Codex Task