Skip to content

fix: aria-label attr and add noreferrer in anchor rel attr#24

Merged
MohamadSalman11 merged 1 commit intolovit-dev:mainfrom
stabldev:fix/aria-label-attr
May 23, 2025
Merged

fix: aria-label attr and add noreferrer in anchor rel attr#24
MohamadSalman11 merged 1 commit intolovit-dev:mainfrom
stabldev:fix/aria-label-attr

Conversation

@stabldev
Copy link
Contributor

Summary

Added aria-label attribute to mobile menu button for screen readers.
Include noreferrer to anchor tags rel attribute with target _blank for old browser support.

Motivation

When the link is opened in a new tab, the referrer information is sent in the referer header and some sensitive data may be exposed in the url to the target site. noreferrer option alone is enough for modern browsers, but including both works perfectly for some old browsers.

Change Type

  • 🐞 Bug fix (non-breaking fix for an issue)
  • ✨ Feature (non-breaking addition)
  • 🧹 Refactor (non-breaking improvements, no behavior change)
  • 💥 Breaking change (fix or feature that would change existing functionality)

Checklist

  • I’ve read the Contributing Guidelines
  • My code matches the project’s coding style (npm run lint)
  • My change introduces changes to the documentation
  • I’ve updated documentation where needed
  • I’ve added tests covering new behavior
  • All existing and new tests pass

Related Issues

@stabldev stabldev changed the title fix: aria-label attr and add noreferrer in anchor rel attr fix(docs): aria-label attr and add noreferrer in anchor rel attr May 23, 2025
@MohamadSalman11 MohamadSalman11 changed the title fix(docs): aria-label attr and add noreferrer in anchor rel attr fix: aria-label attr and add noreferrer in anchor rel attr May 23, 2025
@MohamadSalman11 MohamadSalman11 merged commit cacfcb0 into lovit-dev:main May 23, 2025
5 checks passed
@MohamadSalman11
Copy link
Contributor

@moonlitgrace Looks great — thanks for your improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aria-label="Toggle menu" to mobile menu toggle button for improved accessibility

2 participants