feat: conversational position creation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a conversational flow for creating positions after chart analysis: 1. Added PositionCreationView UI component: - Intelligent extraction of trading data from chart analysis text - Interactive buttons and modals for updating position details - Position type selection with clear visual indicators - Support for entering symbols and prices not detected in analysis 2. Enhanced chart analysis command: - Added "Create Position" button to analysis results - Interactive flow for confirming and modifying position details - Public announcements when positions are created - Support for both slash commands and prefix commands 3. Improved user experience: - Private position creation dialogs for security - Data validation with helpful error messages - Proper cleanup and handling of timeouts - Consistent command references across the app This implementation fulfills the requirement for a conversational position creation flow that starts from chart analysis and guides users through creating positions, with announcements to relevant channels when positions are created. # Conflicts: # src/bots/discord_bot.py
lowhung
force-pushed
the
feature/conversational-position-creation
branch
from
2c3f36e to
fa323f5
Compare
…buttons and display the parameters there, but still give them the option to change them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.