Repository navigation
Conversation
Bumps the npm_and_yarn group with 1 update in the / directory: [undici](https://github.com/nodejs/undici). Updates `undici` from 6.28.0 to 6.29.0 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v6.28.0...v6.29.0) --- updated-dependencies: - dependency-name: undici dependency-version: 6.29.0 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Lock down Axis Mundi-only CRUD defaults and Scope#resolve deny-by-default behavior used by campuses, schools, departments, and other catalog resources. Co-authored-by: rsmoke <rsmoke@umich.edu>
…yarn-7605d37c2e Bump undici from 6.28.0 to 6.29.0 in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 2 updates in the / directory: [dompurify](https://github.com/cure53/DOMPurify) and [source-map-js](https://github.com/7rulnik/source-map-js). Updates `dompurify` from 3.4.13 to 3.4.17 - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](cure53/DOMPurify@3.4.13...3.4.17) Updates `source-map-js` from 1.2.1 to 1.2.2 - [Release notes](https://github.com/7rulnik/source-map-js/releases) - [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md) - [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: dompurify dependency-version: 3.4.17 dependency-type: indirect dependency-group: npm_and_yarn - dependency-name: source-map-js dependency-version: 1.2.2 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: rsmoke <5861173+rsmoke@users.noreply.github.com>
…ge-e7b2 Add ApplicationPolicy default permission and scope regression specs
…yarn-e8088f1dba Bump the npm_and_yarn group across 1 directory with 2 updates
There was a problem hiding this comment.
🔵 Needs a closer look
The unrelated dependency upgrades should be reverted or moved to a separately documented PR.
0 open findings
What changed in this PR
Adds RSpec coverage for ApplicationPolicy authorization defaults and scope resolution.
Changes:
- Tests standard actions for Axis Mundi, regular, and anonymous users.
- Tests role scope visibility by user type.
- Updates three unrelated Yarn dependencies.
| File | Description |
|---|---|
spec/policies/application_policy_spec.rb |
Adds policy and scope tests. |
yarn.lock |
Updates three transitive dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a comprehensive RSpec test suite for the
ApplicationPolicyclass. The new tests verify default action permissions and scope resolution for different user roles, ensuring that authorization logic is correctly enforced.Authorization policy tests:
index,show,create,new,update,edit,destroy), while regular and nil users are denied these actions.Scope#resolvemethod to confirm Axis Mundi users can access all records, while regular and nil users receive no records.