[cursor]

Risky behavior now covered

• Non-admin viewers with a staging LDAP group can show? floor plans but cannot create/update/destroy
• Users without matching membership are denied show? outside production
• Admins can create, update, and destroy floors

Test files added/updated

• spec/policies/floor_policy_spec.rb (new)

Why these tests materially reduce regression risk

FloorPolicy is the authorization gate for building floor-plan uploads and viewing. Untested permission drift could expose floor mutations to viewers or hide plans from authorized non-admins.

Validation

• bundle exec rspec spec/policies/floor_policy_spec.rb — 3 examples, 0 failures (SimpleCov subset minimum coverage exit ignored per prior runs)

  

---

Note

Low Risk
Test-only changes; no application or policy logic modified in this diff.

Overview
Adds regression specs for FloorPolicy so authorization for floor plans is explicitly tested: staging LDAP viewers can show but not mutate; users without matching membership are denied show (non-production); admins can create/update/destroy.

Also tightens TaskResultLog#update_log fallback spec by putting a real validation error on the stubbed ApiUpdateLog and asserting the API logger receives Could not save: result is invalid instead of a placeholder string.

^{Reviewed by Cursor Bugbot for commit 98d97b5. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Copilot]

🟢 Approval recommended

The focused test-only changes match existing policy behavior, with no blocking issues identified.

0 open findings

What changed in this PR

Adds regression coverage for FloorPolicy, the authorization gate for floor-plan viewing and mutations. No application logic changes.

Changes:

• Verifies staging viewers can view floors but cannot mutate them.
• Verifies users without matching membership are denied access outside production.
• Verifies admins can create, update, and destroy floors.

File	Description
spec/​policies/​floor_policy_spec.rb	Adds three authorization regression examples.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.