Repository navigation
Merge okta to main branch / production server - #477
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The SAML configuration removes the existing clock-skew tolerance, potentially causing intermittent authentication failures.
1 open finding
What changed in this PR
Updates SAML authentication for Okta across environments and aligns user attribute mapping.
Changes:
- Configures environment-specific Okta endpoints, certificates, and attributes.
- Maps SAML
display_nameinto users and updates model specs. - Updates Pry dependencies and admin failure messaging.
| File | Description |
|---|---|
app/models/user.rb |
Maps Okta display names. |
spec/models/user_spec.rb |
Updates SAML mapping tests. |
config/initializers/devise.rb |
Configures Okta SAML integration. |
config/credentials.yml.enc |
Updates encrypted environment credentials. |
Gemfile |
Raises Pry minimum versions. |
Gemfile.lock |
Locks updated Pry dependencies. |
app/views/layouts/_header.html.erb |
Revises failure-reporting guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| security: {want_assertions_signed: true, want_assertions_encrypted: true} | ||
| private_key: service_provider_private_key, | ||
| certificate: service_provider_certificate, | ||
| security: {want_assertions_signed: true, want_assertions_encrypted: true}, |
dschmura
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.