Repository navigation
Conversation
…d, and enhance support info modal with improved accessibility and styling.
Cover department lookup success/failure shaping used by BuildingsApi room updates, and ensure Sentry metric failures are swallowed so jobs/rake keep running. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
…463) Cover the success path that hides rooms via visible=false while keeping contacts, characteristics, and Active Storage panoramas/images, plus the already-hidden fail-closed invariant in BuildingsApi and ClassroomApi. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
Cover structured phase/run reporting and runner early-exit when auth token acquisition fails, so nightly classroom sync failures stay visible in ApiUpdateLog without continuing later phases. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
…ory (#465) Bumps the bundler group with 1 update in the / directory: [rubyzip](https://github.com/rubyzip/rubyzip). Updates `rubyzip` from 3.2.2 to 3.4.0 - [Release notes](https://github.com/rubyzip/rubyzip/releases) - [Changelog](https://github.com/rubyzip/rubyzip/blob/main/Changelog.md) - [Commits](rubyzip/rubyzip@v3.2.2...v3.4.0) --- updated-dependencies: - dependency-name: rubyzip dependency-version: 3.4.0 dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: rsmokeUM <rsmoke@umich.edu>
…#467) * Add TaskResultLog, TokenStore, and Okta display_name regression specs Cover nightly API update logging status/payload persistence, token cache expiry and failure paths, and Okta SAML display_name mapping on omniauth callback so auth/name regressions are caught early. Co-authored-by: rsmoke <rsmoke@umich.edu> * Improve error logging in ApiUpdateLog by including detailed error messages when save fails. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
* Add ApplicationHelper api_status and api_log_text regression specs. Cover the admin header banner signals for missing nightly runs, error vs success recency, and blank log fallback so false-positive or missed API failure alerts are less likely to regress. Co-authored-by: rsmoke <rsmoke@umich.edu> * Potential fix for pull request finding 'Test does not verify log recency filtering' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* Add FloorPolicy authorization regression specs. Lock viewer show vs admin mutation permissions and deny show when membership groups are empty outside production. Co-authored-by: rsmoke <rsmoke@umich.edu> * Improve error logging in TaskResultLog specs by including specific error messages for invalid records --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
Lock admin-only index/show/refresh gates so non-admin viewers cannot access API update logs or refresh the analytics dashboard. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: rsmoke <rsmoke@umich.edu>
Co-authored-by: rsmokeUM <rsmoke@umich.edu>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Native-dialog behavior and dependency compatibility still need browser and CI validation before approval.
0 open findings
What changed in this PR
Updates room support dialogs in the Rails application and expands regression coverage for authentication, permissions, and API processing.
Changes:
- Replaces the support overlay with a native dialog and button trigger.
- Updates dependencies and CSS watching, restores SAML clock tolerance, and improves failure logging.
- Adds tests for API clients, update reports, policies, helpers, and metrics.
| File | Description |
|---|---|
| spec/services/sentry_metrics_spec.rb | Tests metric forwarding and failure handling. |
| spec/requests/users/omniauth_callbacks_spec.rb | Tests Okta display-name persistence. |
| spec/policies/floor_policy_spec.rb | Tests floor access permissions. |
| spec/policies/api_update_log_policy_spec.rb | Tests log access permissions. |
| spec/policies/analytics_dashboard_policy_spec.rb | Tests dashboard permissions. |
| spec/lib/um_api_spec.rb | Expands token refresh and failure tests. |
| spec/lib/task_result_log_spec.rb | Tests report persistence and fallback logging. |
| spec/lib/department_api_spec.rb | Tests department responses and pagination. |
| spec/lib/classroom_api_spec.rb | Tests classroom deactivation and media preservation. |
| spec/lib/buildings_api_spec.rb | Tests room deactivation and media preservation. |
| spec/lib/api_update_database/runner_spec.rb | Tests update-run failure handling. |
| spec/lib/api_update_database/run_result_spec.rb | Tests aggregate report results. |
| spec/lib/api_update_database/phase_result_spec.rb | Tests phase tracking and serialization. |
| spec/helpers/application_helper_spec.rb | Tests recent API status and log text. |
| Procfile.dev | Keeps CSS watching active without stdin. |
| lib/auth_token_api.rb | Logs actual validation errors. |
| Gemfile.lock | Updates Tailwind and rubyzip versions. |
| config/initializers/devise.rb | Restores SAML clock-drift tolerance. |
| app/views/rooms/_support_info.html.erb | Uses a native dialog with room-specific labels. |
| app/views/rooms/_room_row.html.erb | Uses a button to open support information. |
| app/assets/builds/tailwind.css | Regenerates CSS with dialog styling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tailwindcss dependencies, modify Procfile for CSS watch comman…
Update Specs
restore allowed_clock_drift in saml attributes (https://github.com/lsa-mis/mi_classrooms/pull/478[)](https://github.com/lsa-mis/mi_classrooms/commit/10800b944fdc84515df5a280450dd3f0b8cbd168)