[rsmoke]

This pull request introduces several improvements and fixes across the codebase, focusing on enhancing the reliability of room deactivation logic, improving modal accessibility and UI, refining logging and API error handling, and adding comprehensive test coverage for critical components. The most significant changes are grouped below.

Room Deactivation Logic Improvements:

• Updated the deactivate_stale_rooms method in both lib/buildings_api.rb and lib/classroom_api.rb to correctly count already hidden rooms as deactivated, ensure only visible or unset rooms are updated, and improve transaction rollback and logging for mismatches. This ensures more accurate and robust handling of room visibility state. [1] [2]
• Added and expanded tests in spec/lib/buildings_api_spec.rb and spec/lib/classroom_api_spec.rb to verify that deactivation hides rooms without deleting related records or media, correctly handles already hidden or unset rooms, and properly rolls back on errors. [1] [2] [3]

Modal Accessibility and UI Enhancements:

• Refactored the support info modal in app/views/rooms/_support_info.html.erb to use the native <dialog> element, improving accessibility with proper ARIA attributes and more semantic structure. Also updated the trigger in app/views/rooms/_room_row.html.erb to use a button instead of a link for better accessibility and interaction. [1] [2] [3]

Logging and API Error Handling:

• Improved error logging in lib/auth_token_api.rb to include detailed error messages when saving logs fails.
• Added a test in spec/lib/api_update_database/runner_spec.rb to ensure that token acquisition failures halt subsequent phases and that phase errors are logged and reported correctly.

Test Coverage and Utilities:

• Added comprehensive specs for ApiUpdateDatabase::PhaseResult and ApiUpdateDatabase::RunResult to ensure correct behavior for incrementing counters, error/warning handling, duration calculation, and structured log serialization. [1] [2]
• Added tests for helper methods in spec/helpers/application_helper_spec.rb to verify correct API status and log text reporting.

Other Small Improvements:

• Allowed a small clock drift for SAML assertions in Devise configuration to improve authentication robustness.
• Updated the Tailwind CSS watcher command in Procfile.dev for improved development experience.

[Copilot]

🔵 Needs a closer look

Dependency, SAML, and browser-dialog changes need human integration validation before approval.

No open issues 🎉

What changed in this PR

Improves room synchronization reliability and support-dialog accessibility in the Rails application, with broader regression coverage.

Changes:

• Handles hidden and unset room visibility correctly and improves failure logging.
• Introduces native dialog markup, updates dependencies and styling, and allows SAML clock drift.
• Expands tests for APIs, authentication, authorization, metrics, and reporting.

File	Description
spec/​services/​sentry_metrics_spec.rb	Tests metric forwarding and failure handling.
spec/​requests/​users/​omniauth_callbacks_spec.rb	Tests SAML display-name persistence.
spec/​policies/​floor_policy_spec.rb	Tests floor access permissions.
spec/​policies/​api_update_log_policy_spec.rb	Tests log access permissions.
spec/​policies/​analytics_dashboard_policy_spec.rb	Tests dashboard permissions.
spec/​lib/​um_api_spec.rb	Tests token expiry and failures.
spec/​lib/​task_result_log_spec.rb	Tests structured logging and save failures.
spec/​lib/​department_api_spec.rb	Tests department API responses.
spec/​lib/​classroom_api_spec.rb	Tests classroom deactivation and preservation.
spec/​lib/​buildings_api_spec.rb	Tests room deactivation and rollback.
spec/​lib/​api_update_database/​runner_spec.rb	Tests token and phase failures.
spec/​lib/​api_update_database/​run_result_spec.rb	Tests run-result serialization.
spec/​lib/​api_update_database/​phase_result_spec.rb	Tests phase counters and reporting.
spec/​helpers/​application_helper_spec.rb	Tests API status and log helpers.
Procfile.dev	Keeps the CSS watcher running.
lib/​classroom_api.rb	Handles hidden and unset classrooms.
lib/​buildings_api.rb	Handles hidden and unset rooms.
lib/​auth_token_api.rb	Logs actual validation errors.
Gemfile.lock	Updates Rubyzip and Tailwind dependencies.
config/​initializers/​devise.rb	Allows ten seconds of SAML clock drift.
app/​views/​rooms/​_support_info.html.erb	Uses native dialog markup and unique labels.
app/​views/​rooms/​_room_row.html.erb	Uses a button to open support information.
app/​assets/​builds/​tailwind.css	Regenerates styles with dialog utilities.

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Concurrent visibility changes can cause false count mismatches and roll back deactivation in both importers.

1 open issue

• Lock targeted rooms before counting to prevent concurrent visibility races · New

_{Review effort: Balanced}