DM-55425: Update ingester so that it can close out when pods scale down - #19
Merged
Merged
Conversation
dspeck1
approved these changes
Aug 11, 2026
dspeck1
left a comment
dspeck1
left a comment
There was a problem hiding this comment.
LGTM. Two comments we reviewed to update.
| self, | ||
| limit: int = -1, | ||
| commit_interval: int = 100, | ||
| auto_offset_reset: str = "latest", |
There was a problem hiding this comment.
Should auto_offset_reset and the other values above be a variables sent in as arguments?
| } | ||
| finally: | ||
| await consumer.stop() | ||
| self._executor.shutdown(wait=False) |
There was a problem hiding this comment.
Does shutdown need to be set to True to allow any tasks to finish?
bsmartradio
force-pushed
the
tickets/DM-55425
branch
from
August 14, 2026 17:23
f814264 to
0a577c9
Compare
Move handle_kafka_message to async so that it doesn't slow things down Move the shutdown to warning so it appears in logs Update ingester to batch process messages and update unit tests Claude assisted Remove excess code and allow for proper multhreading Add arguments
bsmartradio
force-pushed
the
tickets/DM-55425
branch
from
August 14, 2026 18:33
0a577c9 to
0d86a1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.