feat: visualizer waveform, outline rework, and interaction fixes - #36
Merged
Conversation
Adds a third visualizer style ("Waveform") alongside bars and outline.
Five standing-wave lines, one per frequency band group (sub-bass → treble),
animate with irrational speed ratios so their interference stays jagged and
non-repeating. Lines are color-coded per the color-of-sound spectrum on dark
and light themes; colored themes (mint, grape, lemon) instead spread five
hues ±60° around their accent color for a cohesive, theme-matched palette.
Theme detection uses background saturation rather than accent saturation,
which correctly classifies grape (previously misidentified as light theme).
On the Rust side, AnalysisSource now maintains a 512-sample PCM waveform
buffer alongside the existing FFT bands, publishing both in a single
VisualizerPayload event. The standalone rms.rs module is removed; its logic
was already subsumed by AnalysisSource.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replaces per-FFT-band spike tips with five smoothly blended frequency-group sectors so whole arcs of the circle breathe together (matching the waveform line groupings). Three superimposed polar standing waves — sin(3α), sin(5α), sin(7α) — driven at irrational time ratios (0.5, 0.73, 0.43 Hz) add a continuously shifting warbly deformation that never settles into a repeating pattern. Sector boundaries use cosine interpolation to stay smooth. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Space bar now always toggles play/pause while the visualizer is open, bypassing the native-button-activation check that previously let whatever button had focus underneath intercept the keypress. Equalizer popover z-index raised from 100 to 120 (preset list from 101 to 121) so it renders above the visualizer panel (z-index 100) when opened from the transport bar. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sin(3α),sin(5α),sin(7α)) at irrational time ratios for a continuously shifting warbly shapeAnalysisSourcenow publishes a 512-sample PCM waveform buffer alongside FFT bands in a singleVisualizerPayloadevent; the standalonerms.rsmodule is removed (its logic was already subsumed byAnalysisSource)Test plan
Screencast.from.2026-07-15.23-00-12.mp4
🤖 Generated with Claude Code