initial owner, deterministic deploy#2
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Deleverager deployment flow to allow setting an explicit initial owner at construction time, and attempts to make deployments deterministic via CREATE2.
Changes:
- Extend
Deleveragerconstructor to accept aninitialOwnerand pass it toOwnable. - Update the mainnet fork test to use the new constructor signature.
- Update the deploy script to set a fixed emergency owner and deploy via CREATE2 (salted deployment).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
test/Deleverager.t.sol |
Adjusts test setup to use the new constructor signature. |
src/Deleverager.sol |
Adds initialOwner constructor parameter and wires it into Ownable. |
script/DeployDeleverager.s.sol |
Introduces an emergency owner constant and switches deployment to a salted new (CREATE2). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| vm.startBroadcast(); | ||
| Deleverager deleverager = new Deleverager(ltvAddress); | ||
| Deleverager deleverager = new Deleverager{salt: ""}(ltvAddress, EMERGENCY_DELEVERAGER); |
Comment on lines
+8
to
+15
| address constant EMERGENCY_DELEVERAGER = 0x029B9362b5Ee78A673848eb025b533856dD8DDAA; | ||
|
|
||
| contract DeployDeleveragerScript is Script { | ||
| function run() external { | ||
| address ltvAddress = vm.envAddress("LTV_ADDRESS"); | ||
|
|
||
| vm.startBroadcast(); | ||
| Deleverager deleverager = new Deleverager(ltvAddress); | ||
| Deleverager deleverager = new Deleverager{salt: ""}(ltvAddress, EMERGENCY_DELEVERAGER); |
andreysobol
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.