Skip to content

FIX: Correct loading conditions for numeric values#130

Draft
vsevolod-zhuravlov wants to merge 4 commits into
ltvprotocol:devfrom
vsevolod-zhuravlov:fix/loading-conditions-number-checks
Draft

FIX: Correct loading conditions for numeric values#130
vsevolod-zhuravlov wants to merge 4 commits into
ltvprotocol:devfrom
vsevolod-zhuravlov:fix/loading-conditions-number-checks

Conversation

@vsevolod-zhuravlov
Copy link
Copy Markdown
Contributor

No description provided.

@Cycxyz
Copy link
Copy Markdown
Collaborator

Cycxyz commented Dec 26, 2025

image Auction.tsx

@Cycxyz
Copy link
Copy Markdown
Collaborator

Cycxyz commented Dec 26, 2025

VaultBlock.tsx
image

@Cycxyz
Copy link
Copy Markdown
Collaborator

Cycxyz commented Dec 26, 2025

image userMaxAmountUsd.tsx

@Cycxyz
Copy link
Copy Markdown
Collaborator

Cycxyz commented Dec 26, 2025

What was methodology of finding such places? I make a search of strings 'number | null' and 'bigin | null', find variables which defined like that and make a lookup if it's compared to null everywhere or not. Making it I'm finding places where it isn't done. So why did you pick places which you picked

@vsevolod-zhuravlov
Copy link
Copy Markdown
Contributor Author

What was methodology of finding such places? I make a search of strings 'number | null' and 'bigin | null', find variables which defined like that and make a lookup if it's compared to null everywhere or not. Making it I'm finding places where it isn't done. So why did you pick places which you picked

It's just be "audited" by ai, so now I agree that it's was wrong method, because it skips a lot of places. I'll fix all of this

@Cycxyz
Copy link
Copy Markdown
Collaborator

Cycxyz commented Jan 6, 2026

@Cycxyz Cycxyz marked this pull request as draft January 6, 2026 19:10
@vsevolod-zhuravlov
Copy link
Copy Markdown
Contributor Author

About Auction.tsx in line 261 I think everything is good, because if both balues is zero, then we shouldn't to show any info about auction, because it's no auction right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants