-
Notifications
You must be signed in to change notification settings - Fork 0
Update #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: globus
Are you sure you want to change the base?
Update #39
Changes from all commits
279b282
9824b62
639f4c9
162a40f
561f24b
d045f1a
a4c7537
0c01e22
c095efc
485bd01
37aeff2
8db3dd2
b4fe522
15f5c5e
f1846a2
efc63e8
cbd6381
9744886
2eb686c
15695c7
29e8fab
c8d74ca
4234b99
87ffbaa
7e5b553
791f617
2c5fd3c
329b167
8b198d1
d1660b9
ed0b1e9
05c503e
3642eda
bf72357
316fbb3
1addebd
544fdcf
f6d5e8d
98e4820
ac3fd32
8e8966d
89cf927
055ae30
7c47505
30be73c
0c7d3a6
2d7bd80
149ebde
05a961e
879c465
35a1eb2
b96efcf
d9b59ca
63db903
459af37
3163b52
ee079f1
05f9b92
173b1be
4c18c18
9cdcb63
18a462e
776e3fd
5205954
d55acc6
5116b54
36ab0c4
1fb88c3
34a6797
c2b670b
0f954ed
cc995bd
f32f1be
467982f
65daf36
3ebcd97
23f9005
40565fe
dd712ba
3d1c80e
77bb684
5bb915c
c1c7cb4
ca2349a
5cb200f
62480e2
a7fdd36
9baa523
146fc1a
910142f
a764057
b77e0b9
5a35f2a
6471790
1247390
f463777
419d1f2
ac097c8
4c175a2
c78e1c2
e5ca6e4
5516947
dd642d0
c8b949c
13b371b
75f7ef7
72ae455
6a5b3cd
07a21f5
5d95b8f
570b706
e851566
1e238ad
dcff397
f3215a9
bace5f9
e9610de
67d7028
7639a3a
5ef6665
acaabde
04a63db
ec01449
df15374
1703f21
0c5ef01
8ed62f6
cb48a82
ccd056c
dda0fce
8635fa5
ccfb88a
0d04443
721a2df
3914474
3fc1382
326aa5e
fc461a6
f252c6a
a98b5a5
2965502
697904e
0b8ce93
a66195d
ed086df
8158910
b60a0fb
5c780e3
1245477
860eae4
7b3137b
3023f9d
ff86b1a
a0e6b29
b0bb896
83dc70b
8406879
ee335d3
971c11f
e20213c
b407bcb
0fc8671
9cc829f
2cffaa9
da0ed77
0fef4e4
e9d86be
df9905c
0bb6296
c65b138
3a05c73
964b406
2cc1750
687e901
372e688
29c1266
6e29c58
cd01fd5
ed1a30b
d8e969d
edbadfa
0d31d98
eaae6a0
c21c05e
19dbc68
79d42fe
2ca6722
765f873
768c500
27e1f1f
9b1b478
61e36f4
ad8c020
9874f4d
914c264
6f0183b
df216cb
d382da6
4dfb47b
80fd9f7
6658f45
1bba876
512e97f
5dc8b47
ed8fd70
3d19a37
acbf825
48636f6
dec0372
d649ecf
90a1219
6a144ac
4370bb7
42aa30c
af9d040
b2a993e
7dbc6da
83671e8
50d04e6
0cebb9c
358aa9d
cd8c43e
ef8b3c5
b28c6c5
ef31191
7edf3a0
98f448e
cb9728a
e3797e3
b21131f
a1bc4fd
7054b64
d0762e7
6b188a4
5727c1b
3377d76
823c754
c397418
217ef23
ec1b65b
4069180
a07a2f8
0d5883d
0e2a7b6
df16252
353c383
a0cf2ef
718b114
2eb10cc
7904e99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| APP_IMAGE=gdcc/dataverse:unstable | ||
| POSTGRES_VERSION=17 | ||
| DATAVERSE_DB_USER=dataverse | ||
| SOLR_VERSION=9.8.0 | ||
| SKIP_DEPLOY=0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| # https://www.git-scm.com/docs/gitattributes | ||
|
|
||
| # This set mandatory LF line endings for .sh files preventing from windows users to having to change the value of their git config --global core.autocrlf to 'false' or 'input' | ||
| *.sh text eol=lf |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
|
|
||
| # Any container related stuff should be assigned to / reviewed by Oliver and/or Phil | ||
| modules/container-configbaker/** @poikilotherm @pdurbin | ||
| modules/container-base/** @poikilotherm @pdurbin | ||
| src/main/docker/** @poikilotherm @pdurbin | ||
| docker-compose-dev.yml @poikilotherm @pdurbin | ||
| .github/workflows/scripts/containers** @poikilotherm @pdurbin | ||
| .github/workflows/container_* @poikilotherm @pdurbin |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Did you encounter something unexpected or incorrect in the Dataverse software? | ||
| We'd like to hear about it! | ||
| title: '' | ||
| labels: 'Type: Bug' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a bug report! | ||
|
|
||
| WARNING: If this is a security issue it should be reported privately to security@dataverse.org | ||
|
|
||
| More information on bug issues and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
| **What steps does it take to reproduce the issue?** | ||
|
|
||
| * When does this issue occur? | ||
|
|
||
|
|
||
| * Which page(s) does it occurs on? | ||
|
|
||
|
|
||
| * What happens? | ||
|
|
||
|
|
||
| * To whom does it occur (all users, curators, superusers)? | ||
|
|
||
|
|
||
| * What did you expect to happen? | ||
|
|
||
|
|
||
|
|
||
| **Which version of Dataverse are you using?** | ||
|
|
||
|
|
||
|
|
||
| **Any related open or closed issues to this bug report?** | ||
|
|
||
|
|
||
| **Screenshots:** | ||
|
|
||
| No matter the issue, screenshots are always welcome. | ||
|
|
||
| To add a screenshot, please use one of the following formats and/or methods described here: | ||
|
|
||
| * https://help.github.com/en/articles/file-attachments-on-issues-and-pull-requests | ||
| * | ||
|
|
||
|
|
||
| **Are you thinking about creating a pull request for this issue?** | ||
| Help is always welcome, is this bug something you or your organization plan to fix? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea or new feature for the Dataverse software! | ||
| title: 'Feature Request:' | ||
| labels: 'Type: Feature' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a feature request! | ||
|
|
||
| More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
|
|
||
| **Overview of the Feature Request** | ||
|
|
||
|
|
||
| **What kind of user is the feature intended for?** | ||
| (Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin) | ||
|
|
||
|
|
||
| **What inspired the request?** | ||
|
|
||
|
|
||
| **What existing behavior do you want changed?** | ||
|
|
||
|
|
||
| **Any brand new behavior do you want to add to Dataverse?** | ||
|
|
||
|
|
||
| **Any open or closed issues related to this feature request?** | ||
|
|
||
| **Are you thinking about creating a pull request for this feature?** | ||
| Help is always welcome, is this feature something you or your organization plan to implement? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| --- | ||
| name: Idea proposal | ||
| about: Propose a new idea for discussion to improve the Dataverse software! | ||
| title: 'Suggestion:' | ||
| labels: 'Type: Suggestion' | ||
| assignees: '' | ||
|
|
||
| --- | ||
|
|
||
| <!-- | ||
| Thank you for contributing to the Dataverse Project through the creation of a feature request! | ||
|
|
||
| More information on ideas/feature requests and contributions can be found in the "Contributing to Dataverse" page: | ||
| https://guides.dataverse.org/en/latest/contributor/index.html | ||
|
|
||
| Please fill out as much of the template as you can. | ||
| Start below this comment section. | ||
| --> | ||
|
|
||
| **Overview of the Suggestion** | ||
|
|
||
|
|
||
| **What kind of user is the suggestion intended for?** | ||
| (Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin) | ||
|
|
||
|
|
||
| **What inspired this idea?** | ||
|
|
||
|
|
||
| **What existing behavior do you want changed?** | ||
|
|
||
|
|
||
| **Any brand new behavior do you want to add to Dataverse?** | ||
|
|
||
|
|
||
| **Any open or closed issues related to this suggestion?** | ||
|
|
||
|
|
||
| **Are you thinking about creating a pull request for this issue?** | ||
| Help is always welcome, is this idea something you or your organization plan to implement? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| **What this PR does / why we need it**: | ||
|
|
||
| **Which issue(s) this PR closes**: | ||
|
|
||
| - Closes # | ||
|
|
||
| **Special notes for your reviewer**: | ||
|
|
||
| **Suggestions on how to test this**: | ||
|
|
||
| **Does this PR introduce a user interface change? If mockups are available, please link/include them here**: | ||
|
|
||
| **Is there a release notes update needed for this change?**: | ||
|
|
||
| **Additional documentation**: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Security | ||
|
|
||
| To report a security vulnerability please email security@dataverse.org as explained at https://guides.dataverse.org/en/latest/installation/config.html#reporting-security-issues | ||
|
|
||
| Advice on securing your installation can be found at https://guides.dataverse.org/en/latest/installation/config.html#securing-your-installation | ||
|
|
||
| Security practices and procedures used by the Dataverse team are described at https://guides.dataverse.org/en/latest/developers/security.html |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| --- | ||
| name: "Setup Maven and Caches" | ||
| description: "Determine Java version and setup Maven, including necessary caches." | ||
| inputs: | ||
| git-reference: | ||
| description: 'The git reference (branch/tag) to check out' | ||
| required: false | ||
| default: '${{ github.ref }}' | ||
| pom-paths: | ||
| description: "List of paths to Maven POM(s) for cache dependency setup" | ||
| required: false | ||
| default: 'pom.xml' | ||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v5 | ||
| with: | ||
| ref: ${{ inputs.git-reference }} | ||
| - name: Determine Java version by reading the Maven property | ||
| shell: bash | ||
| run: | | ||
| echo "JAVA_VERSION=$(grep '<target.java.version>' ${GITHUB_WORKSPACE}/modules/dataverse-parent/pom.xml | cut -f2 -d'>' | cut -f1 -d'<')" | tee -a ${GITHUB_ENV} | ||
| - name: Set up JDK ${{ env.JAVA_VERSION }} | ||
| id: setup-java | ||
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: ${{ env.JAVA_VERSION }} | ||
| distribution: 'temurin' | ||
| cache: 'maven' | ||
| cache-dependency-path: ${{ inputs.pom-paths }} | ||
| - name: Download common cache on branch cache miss | ||
| if: ${{ steps.setup-java.outputs.cache-hit != 'true' }} | ||
| uses: actions/cache/restore@v4 | ||
| with: | ||
| key: dataverse-maven-cache | ||
| path: ~/.m2/repository |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Set update schedule for GitHub Actions | ||
| # https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/keeping-your-actions-up-to-date-with-dependabot | ||
|
|
||
| version: 2 | ||
| updates: | ||
|
|
||
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| # Check for updates to GitHub Actions daily | ||
| interval: "daily" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Add bugs to project board | ||
|
|
||
| on: | ||
| issues: | ||
| types: | ||
| - opened | ||
| - labeled | ||
|
|
||
| jobs: | ||
| add-to-project: | ||
| name: Add bug to project | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/add-to-project@v1.0.2 | ||
| with: | ||
| project-url: https://github.com/orgs/IQSS/projects/34 | ||
| github-token: ${{ secrets.ADD_TO_PROJECT_PAT }} | ||
| labeled: "Type: Bug" | ||
| Original file line number | Diff line number | Diff line change | |||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,32 @@ | |||||||||||||||||||||||||||||
| name: "Properties Check" | |||||||||||||||||||||||||||||
| on: | |||||||||||||||||||||||||||||
| pull_request: | |||||||||||||||||||||||||||||
| paths: | |||||||||||||||||||||||||||||
| - "src/**/*.properties" | |||||||||||||||||||||||||||||
| - "scripts/api/data/metadatablocks/*" | |||||||||||||||||||||||||||||
| jobs: | |||||||||||||||||||||||||||||
| duplicate_keys: | |||||||||||||||||||||||||||||
| name: Duplicate Keys | |||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||||||||||||||
| steps: | |||||||||||||||||||||||||||||
| - uses: actions/checkout@v6 | |||||||||||||||||||||||||||||
| - name: Run duplicates detection script | |||||||||||||||||||||||||||||
| shell: bash | |||||||||||||||||||||||||||||
| run: tests/check_duplicate_properties.sh | |||||||||||||||||||||||||||||
|
|
|||||||||||||||||||||||||||||
| metadata_blocks_properties: | |||||||||||||||||||||||||||||
|
Comment on lines
+9
to
+17
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copilot AutofixAI 15 days ago Add an explicit top-level
Best single fix without changing functionality: in
Suggested changeset
1
.github/workflows/check_property_files.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
|||||||||||||||||||||||||||||
| name: Metadata Blocks Properties | |||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | |||||||||||||||||||||||||||||
| steps: | |||||||||||||||||||||||||||||
| - uses: actions/checkout@v6 | |||||||||||||||||||||||||||||
| - name: Setup GraalVM + Native Image | |||||||||||||||||||||||||||||
| uses: graalvm/setup-graalvm@v1 | |||||||||||||||||||||||||||||
| with: | |||||||||||||||||||||||||||||
| github-token: ${{ secrets.GITHUB_TOKEN }} | |||||||||||||||||||||||||||||
| java-version: '21' | |||||||||||||||||||||||||||||
| distribution: 'graalvm-community' | |||||||||||||||||||||||||||||
| - name: Setup JBang | |||||||||||||||||||||||||||||
| uses: jbangdev/setup-jbang@main | |||||||||||||||||||||||||||||
| - name: Run metadata block properties verification script | |||||||||||||||||||||||||||||
| shell: bash | |||||||||||||||||||||||||||||
| run: tests/verify_mdb_properties.sh | |||||||||||||||||||||||||||||
|
Comment on lines
+18
to
+32
Check warningCode scanning / CodeQL Workflow does not contain permissions Medium
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
Copilot AutofixAI 15 days ago Add an explicit workflow-level Best fix (without changing functionality): in permissions:
contents: readdirectly under the
Suggested changeset
1
.github/workflows/check_property_files.yml
Copilot is powered by AI and may make mistakes. Always verify output.
Refresh and try again.
|
|||||||||||||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| # For most projects, this workflow file will not need changing; you simply need | ||
| # to commit it to your repository. | ||
| # | ||
| # You may wish to alter this file to override the set of languages analyzed, | ||
| # or to provide custom queries or build logic. | ||
| # | ||
| # ******** NOTE ******** | ||
| # We have attempted to detect the languages in your repository. Please check | ||
| # the `language` matrix defined below to confirm you have the correct set of | ||
| # supported CodeQL languages. | ||
| # | ||
| name: "CodeQL Advanced" | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "develop", "master" ] | ||
| pull_request: | ||
| branches: [ "develop", "master" ] | ||
| schedule: | ||
| - cron: '30 6 * * 4' | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze (${{ matrix.language }}) | ||
| # Runner size impacts CodeQL analysis time. To learn more, please see: | ||
| # - https://gh.io/recommended-hardware-resources-for-running-codeql | ||
| # - https://gh.io/supported-runners-and-hardware-resources | ||
| # - https://gh.io/using-larger-runners (GitHub.com only) | ||
| # Consider using larger runners or machines with greater resources for possible analysis time improvements. | ||
| runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||
| permissions: | ||
| # required for all workflows | ||
| security-events: write | ||
|
|
||
| # required to fetch internal or private CodeQL packs | ||
| packages: read | ||
|
|
||
| # only required for workflows in private repositories | ||
| actions: read | ||
| contents: read | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - language: actions | ||
| build-mode: none | ||
| - language: java-kotlin | ||
| build-mode: none # This mode only analyzes Java. Set this to 'autobuild' or 'manual' to analyze Kotlin too. | ||
| - language: javascript-typescript | ||
| build-mode: none | ||
| - language: python | ||
| build-mode: none | ||
| # CodeQL supports the following values keywords for 'language': 'actions', 'c-cpp', 'csharp', 'go', 'java-kotlin', 'javascript-typescript', 'python', 'ruby', 'swift' | ||
| # Use `c-cpp` to analyze code written in C, C++ or both | ||
| # Use 'java-kotlin' to analyze code written in Java, Kotlin or both | ||
| # Use 'javascript-typescript' to analyze code written in JavaScript, TypeScript or both | ||
| # To learn more about changing the languages that are analyzed or customizing the build mode for your analysis, | ||
| # see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning. | ||
| # If you are analyzing a compiled language, you can modify the 'build-mode' for that language to customize how | ||
| # your codebase is analyzed, see https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/codeql-code-scanning-for-compiled-languages | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v6 | ||
|
|
||
| # Add any setup steps before running the `github/codeql-action/init` action. | ||
| # This includes steps like installing compilers or runtimes (`actions/setup-node` | ||
| # or others). This is typically only required for manual builds. | ||
| # - name: Setup runtime (example) | ||
| # uses: actions/setup-example@v1 | ||
|
|
||
| # Initializes the CodeQL tools for scanning. | ||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@v4 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| build-mode: ${{ matrix.build-mode }} | ||
| # If you wish to specify custom queries, you can do so here or in a config file. | ||
| # By default, queries listed here will override any specified in a config file. | ||
| # Prefix the list here with "+" to use these queries and those in the config file. | ||
|
|
||
| # For more details on CodeQL's query packs, refer to: https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs | ||
| # queries: security-extended,security-and-quality | ||
|
|
||
| # If the analyze step fails for one of the languages you are analyzing with | ||
| # "We were unable to automatically build your code", modify the matrix above | ||
| # to set the build mode to "manual" for that language. Then modify this step | ||
| # to build your code. | ||
| # ℹ️ Command-line programs to run using the OS shell. | ||
| # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun | ||
| - if: matrix.build-mode == 'manual' | ||
| shell: bash | ||
| run: | | ||
| echo 'If you are using a "manual" build mode for one or more of the' \ | ||
| 'languages you are analyzing, replace this with the commands to build' \ | ||
| 'your code, for example:' | ||
| echo ' make bootstrap' | ||
| echo ' make release' | ||
| exit 1 | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@v4 | ||
| with: | ||
| category: "/language:${{matrix.language}}" |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI 15 days ago
Add an explicit
permissionsblock to the workflow (or job) with least privilege.Best single fix here: add a workflow-level permissions block with
contents: read, since this job does not require broaderGITHUB_TOKENaccess and uses a PAT for project updates. This preserves existing functionality while ensuringGITHUB_TOKENis constrained.Edit only
.github/workflows/add_bugs_to_project.yml, insertingpermissions:after the trigger section (on:block) and beforejobs:.